Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4725876pxj; Wed, 12 May 2021 11:48:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyu+o8oLnyTtfXevURtCUNWP/8Y8RetcXbwR/S6qOli+lvnKFhF+nf2naMzrre6AkazusUh X-Received: by 2002:a17:907:2cc2:: with SMTP id hg2mr37269754ejc.62.1620845221870; Wed, 12 May 2021 11:47:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620845221; cv=none; d=google.com; s=arc-20160816; b=IVyS3Qba8RR9xEovnd7qJbYPQkYMUdMoVh/wiV67ceTWkZk/IjM7+ible5IXvDoVQF 1TykrMUNL4TT5RChQdJP4tKPNaae/r9MJ2nhYzG1UGdQqPBhY9cSYvY2feAWvHaXbpw0 5XRGaGW/hj7TNon5oXIy7QSaQl7F5H5zoAd2PHcQMxL46IgrKwlvJf5aPY8WGs3jr/r5 CqaF38AkaKXRsoelHFSpOw38T00SIAyZ7kZWIXiHVacgmXGcMohImmnEU66XJ1cznwqu A6gZnrYa0W1D3CsWN9qf1+5V8Bxm2iRj1yljllCENh/KxZMMWuhbSlUTBODfvOKBfiyT zqPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BPCl7pRTxzFO4wa3OYr0Sy5jcJQSPAruHGUIkJM9aDM=; b=DdzpsR1iFCfVJCZdO4JCvwht1U5CFTAWVIC01MwdnmAkN51JqO1ikJKqao7yiopvNC WJHMqQakbEAuyNPoPsPVUbfJGrF5bAjS3zdpmFd555XoAkS4s/iPYN0NeeWdTwbjNg1l v10OoMhjSwie0uGgVaJseMJnaTkEJQKl2l/D0xbhr4ALWOxWtuAHuf840Xq4gL+eYw4E ULzuyffYANQblpYPFib3klfIisvft4B/PfRuq41VWC4/N4WcgI+/teDR/IUpseIZ5hwf v2Dcje/uC2XUP6IJmtwjzR7CXpYHs6EeDSoNUffzfIqdsl6XogiyKL4GeFuCLYRKUYry 6wRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FnpwyzxE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qw25si724249ejb.468.2021.05.12.11.46.38; Wed, 12 May 2021 11:47:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FnpwyzxE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358148AbhELSmp (ORCPT + 99 others); Wed, 12 May 2021 14:42:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:60668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243531AbhELQl3 (ORCPT ); Wed, 12 May 2021 12:41:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5DEC061CDB; Wed, 12 May 2021 16:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835472; bh=+fdpF4ceR9o7Lg5jDJOEU23yKQ0PnMiZJJ1nz2EbVf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FnpwyzxEz5pxl7KlY1Glv1DzeLOmwaMZaJ+KoUDl0mndWUDubfrD/tS7vQJD4eSZB bZBVQkFjbTfS0Abvj8ujbiEg5eEd4fOeZ9sN5WtSp0XdKQfqUJ+oBAHT2M32uaER9s 5b4LxEUTg6dacPUZqCbSNxPt0AoevDAJ4Xo+EOok= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthias Schiffer , Sebastian Reichel , Sasha Levin Subject: [PATCH 5.12 358/677] power: supply: bq27xxx: fix sign of current_now for newer ICs Date: Wed, 12 May 2021 16:46:44 +0200 Message-Id: <20210512144849.219586070@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthias Schiffer [ Upstream commit b67fdcb7099e9c640bad625c4dd6399debb3376a ] Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now") changed the sign of current_now for all bq27xxx variants, but on BQ28Z610 I'm now seeing negated values *with* that patch. The GTA04/Openmoko device that was used for testing uses a BQ27000 or BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. Revert the behaviour for newer ICs. Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" Signed-off-by: Matthias Schiffer Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/bq27xxx_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 0262109ac285..20e1dc8a87cf 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1804,7 +1804,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di, val->intval = curr * BQ27XXX_CURRENT_CONSTANT / BQ27XXX_RS; } else { /* Other gauges return signed value */ - val->intval = -(int)((s16)curr) * 1000; + val->intval = (int)((s16)curr) * 1000; } return 0; -- 2.30.2