Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4732478pxj; Wed, 12 May 2021 11:58:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJss7D3GzBogSY6TzgrQIZa/TekYGuSt/c6m0qV1tZMc1Wkvk3360qSLlYeKuor9GMSavg X-Received: by 2002:a05:6402:341:: with SMTP id r1mr45099761edw.113.1620845881006; Wed, 12 May 2021 11:58:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620845881; cv=none; d=google.com; s=arc-20160816; b=gKJ2HAipMzCvFRyMd4vg1q61Qmkv/rMZoaDW+vFhYxnThizyKpc0wnOD0NvFKWb4QX cXDOjkjJ7j7XXFiarMjRMY33G+HLt7PX7mJV9GIeTFUvSJr9w8gkZgLfGclx1NWZ1+FO AmyjheW+0fYl64b1Ly+NoR1XlgPq4Io6SqGXKniCiCRJ4qqRoz5aZlkuP+xdZTQJvYEv K7B9pwV0A/oVD1BQ0jOLZVewu/9MX+VjM3fXZY/zeEI7tyFA/l9s/gGdIw86zq7hnU74 6luw4BCsFpsOot7Z6bnLhVyUTFvdMWn8yzrqeM4YL84mMHWEUpMLRQCbvD2Z3wyBfgWi A2NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zb2t5qrEdkO5u78auu7uyAy7vD5Sw7FcHc0U0/jRCcI=; b=mSDVoRjxs92ihPSiJJGIolr/AfIYuSNylcoiWZX+k/ao4PzYLXO7XXpYFDUg1QGBjU VDlNQMx20ZbMdYfE4Tsyu3i3ZftLxjaQFMQFpDe9J8oULMutF97+4rM6dYPC2bP0iknM 7ve7UpvRnErIjctbqJRyvbl7bgjosCTqlBrlT5mgP8hjDVwaWyY2mW9p/9T/leYbLWKf ce/amymWgSY+koU5WwSW/7xSsc61frAIwFGuuaHU1lI5fjH78H9h/VpME8cM23U1Q3Ep OG5rCGhn5nFSpEyLJ7wxAY2Gdizwo/ajYJbINaMldudNVwODimLdWQSIzcCanCyC1rOY VE6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="O3/zfKj4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si380680edy.288.2021.05.12.11.57.37; Wed, 12 May 2021 11:58:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="O3/zfKj4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358681AbhELSon (ORCPT + 99 others); Wed, 12 May 2021 14:44:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:35790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243692AbhELQlz (ORCPT ); Wed, 12 May 2021 12:41:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BECCB61987; Wed, 12 May 2021 16:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835550; bh=PyFGvfhk7xya12f2/RRkWnHF24kuyTZC0Bo5HEho3v4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O3/zfKj4Mr5p5MWN6ztJIXxi8W9ckYXfL94Ol9kcMfuq3wGsEzAF7j+Wr3SAe7o1o K+vyRT08NPDgrPPVNsNyNEaqksIu3xbzxeAARARM/Mnhz+a522WhG+AzjN2zlFP8ye kMsx8KjSXtNgRpgiIuAlHqgFpPcSYHzKs+picxhY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurent Pinchart , Sakari Ailus , Bingbu Cao , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.12 390/677] media: ipu3-cio2: Fix pixel-rate derived link frequency Date: Wed, 12 May 2021 16:47:16 +0200 Message-Id: <20210512144850.282971428@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sakari Ailus [ Upstream commit a7de6eac6f6f73d48d97a6c93032107775f4593b ] The driver uses v4l2_get_link_freq() helper to obtain the link frequency using the LINK_FREQ but also the PIXEL_RATE control. The divisor for the pixel rate derived link frequency was wrong, missing the bus uses double data rate. Fix this. Reported-by: Laurent Pinchart Fixes: 4b6c129e87a3 ("media: ipu3-cio2: Use v4l2_get_link_freq helper") Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Reviewed-by: Bingbu Cao Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c index 6e8c0c230e11..fecef85bd62e 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c @@ -302,7 +302,7 @@ static int cio2_csi2_calc_timing(struct cio2_device *cio2, struct cio2_queue *q, if (!q->sensor) return -ENODEV; - freq = v4l2_get_link_freq(q->sensor->ctrl_handler, bpp, lanes); + freq = v4l2_get_link_freq(q->sensor->ctrl_handler, bpp, lanes * 2); if (freq < 0) { dev_err(dev, "error %lld, invalid link_freq\n", freq); return freq; -- 2.30.2