Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4742678pxj; Wed, 12 May 2021 12:10:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrx4fyQhUV2eUD41yeVenq8kYo3+ck1UnisqLkNaaRbchk2iP8mi3A1PEGo9jXg8rHPiak X-Received: by 2002:a17:906:b2c1:: with SMTP id cf1mr29750536ejb.544.1620846648416; Wed, 12 May 2021 12:10:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620846648; cv=none; d=google.com; s=arc-20160816; b=EqqZxm6wG7jsBmH/1wiEMyo4S0ur+Yt+8A5bWBIo2MwaRUnkvbmYVBkKSvTltEKLNv j2JyYYHXNhoZFz+KzVFWP/X5ezXaL6RRxWV67zptVKYBxmREY5C8+Em/ucofgpJs5GvB S2lffqvm9USF4nh0wEmnLeH9ds6ywnehn//CO+3NEvvh7WOysA8wx7iCvFfrMAkRsBQp hOFhUAGHNjsC0314sQP7YNLs8jwoUfCoSNtI9hN/Il53vYpKuz2fFBbItGG33PF0bryt 9Xxwa1oFXNhKjkHl4DsXq813DX0ffoTW/7G3fclutMdnY936wEQJdaxscyuyu57W737t XhKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cgdi9fu0w+TUtMrBHbE8YYQL2WW8w5IZYxtD6lLYJKM=; b=R3P+/3T58CWfHCjEzZoRg2OLfdw/lTpCeeay/a9cDK4ZvzjNJ876Vck47dDSj/59dr HInaeOIEDbJOx1Knnztb50LqzzFQ9eaxVtu7iEOT6JW8OfmkXWeMU8do0OG8vQ6mwGlQ cQIH9PANALwU0By+XdyG+Ym5zP8NeTugA6vzJWLBl3fl8l4bOWrw7uMMBv8IPa+YfbKX tXleyxKZclZY8VuMXlinipuQgqX3ru5Dinnr1vmtQgsxrz64COP6O0UXm4ZoBDHCWmbH v/SraG4CZ2dhd0qWqAj7tTbbue/UQmICk749ApxzidWjXhx4EvtfSDRh9tUDj0yLQx1c WYxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0bZOKnx0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si947197ejl.283.2021.05.12.12.10.23; Wed, 12 May 2021 12:10:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0bZOKnx0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358561AbhELTCS (ORCPT + 99 others); Wed, 12 May 2021 15:02:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:35814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244060AbhELQma (ORCPT ); Wed, 12 May 2021 12:42:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6AC6E61D1B; Wed, 12 May 2021 16:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835806; bh=lsjfootg/jtAdyH6K1xx+vOx6exyPiqV9fbXer3OXJw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0bZOKnx0ZE/bahg3uRMLMlq9mB3fZixiz81+KHDzJrDxiKS0xqJ2w3lfa0ePEhnBV Iak0gvnn31or/tqFpWWui3sLYlk+T2/H/qKpaiGF2PAsAL5vm+1LQMrGVTgQcD/HH/ hwGqhvHpWP8aQuMF0ihp3e06sa2AaGzJ+elokfg8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 5.12 457/677] net: dsa: bcm_sf2: fix BCM4908 RGMII reg(s) Date: Wed, 12 May 2021 16:48:23 +0200 Message-Id: <20210512144852.547104479@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafał Miłecki [ Upstream commit 6859d91549341c2ad769d482de58129f080c0f04 ] BCM4908 has only 1 RGMII reg for controlling port 7. Fixes: 73b7a6047971 ("net: dsa: bcm_sf2: support BCM4908's integrated switch") Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/dsa/bcm_sf2.c | 11 +++++++---- drivers/net/dsa/bcm_sf2_regs.h | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index cd64b7f471b5..9c86cacc4a72 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -36,7 +36,12 @@ static u16 bcm_sf2_reg_rgmii_cntrl(struct bcm_sf2_priv *priv, int port) { switch (priv->type) { case BCM4908_DEVICE_ID: - /* TODO */ + switch (port) { + case 7: + return REG_RGMII_11_CNTRL; + default: + break; + } break; default: switch (port) { @@ -1179,9 +1184,7 @@ static const u16 bcm_sf2_4908_reg_offsets[] = { [REG_PHY_REVISION] = 0x14, [REG_SPHY_CNTRL] = 0x24, [REG_CROSSBAR] = 0xc8, - [REG_RGMII_0_CNTRL] = 0xe0, - [REG_RGMII_1_CNTRL] = 0xec, - [REG_RGMII_2_CNTRL] = 0xf8, + [REG_RGMII_11_CNTRL] = 0x014c, [REG_LED_0_CNTRL] = 0x40, [REG_LED_1_CNTRL] = 0x4c, [REG_LED_2_CNTRL] = 0x58, diff --git a/drivers/net/dsa/bcm_sf2_regs.h b/drivers/net/dsa/bcm_sf2_regs.h index c7783cb45845..9e141d1a0b07 100644 --- a/drivers/net/dsa/bcm_sf2_regs.h +++ b/drivers/net/dsa/bcm_sf2_regs.h @@ -21,6 +21,7 @@ enum bcm_sf2_reg_offs { REG_RGMII_0_CNTRL, REG_RGMII_1_CNTRL, REG_RGMII_2_CNTRL, + REG_RGMII_11_CNTRL, REG_LED_0_CNTRL, REG_LED_1_CNTRL, REG_LED_2_CNTRL, -- 2.30.2