Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4744076pxj; Wed, 12 May 2021 12:12:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdKcClHdlZLIuAdkQFRUTh+PjB6Gmpx13oT5lqWdiS+USeW2D5FsBE9lnpjOwmifEx9hMV X-Received: by 2002:aa7:c349:: with SMTP id j9mr44482253edr.230.1620846765731; Wed, 12 May 2021 12:12:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620846765; cv=none; d=google.com; s=arc-20160816; b=opTQlWA871Eb20NSu2paG54zaS1IQc8kgy/wjrgsfuWp8w+RvyxrY39qjgHp8nVkjx 3tc+w0J8GKYfbzAXLo/Xiq0W6/hs60+cCrL2/XnBa4C5UDZWFhHC94125VNR2sc9BuB9 tyi4LShY+TUyjIQNW9x61q4eLn6kq7InP2jxygi9m7OGPWXFU51YSNIn7UMaDEy8d5LC 0iky6bhAAZpuR14XldN2aSSIQJvzYDsHnZQMup3afM4dvvxzt1Kcso0HgJ8yxwd+OmK3 VxGfGGtzJNrAYqRSE8u4sn5HhudSdbkRrrht+88QVlDTinEsN49SsMrZObx33AYXVGdJ G0Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w7NdzPlyN1r85iQpgt1S3A+N7afp52QDRWQpMFsjwyc=; b=OjgC6x8lWSXe1IxlpLt0HjRAlISHmkKzYyeynEzSx7bKgFvxcjh0d0mTGNh6lqX5lt B9t77mC0rnOAPzv/IAE0vWfJgaS30MUM8o1PnhUU2iUnW2eqBALI0+HxwtY7KNiobfmd YOmrZA5t3MdS0oV6C/fZA9yHJ8XAYhkreV3F+ltMHjeIpOBDs74++UDud+Tlpk5TgskA KLgHPuGlW7DcfxiUpsX9u27nNPSvFpVHIB7dEG6oalFJhKQVsRByN8wB57B22vSUVHZ4 btuBd2u1zr+T3Hi5D4TpM6h+otjPkAVZNDzUYEx7EgyCk+yv5LrS1e8/r33F7kcQt4sN y4NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mMecXKxa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k4si460675edv.523.2021.05.12.12.12.21; Wed, 12 May 2021 12:12:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mMecXKxa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244088AbhELTFt (ORCPT + 99 others); Wed, 12 May 2021 15:05:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:35798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244221AbhELQmo (ORCPT ); Wed, 12 May 2021 12:42:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E3E7261CAC; Wed, 12 May 2021 16:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835900; bh=82GIn4amv/A0EWE6fXs7TcI8A216q1f4D+kq0d9Prrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mMecXKxa7WRiWLrUY2zK9gT/SFyOJimuA/KAIiSQt9h15szWlzGPSwVl2pb2SXFsF CosGF9/PGm8BPod6Mrt/pN7h76niKfyPVLTdLaeIM/e7EhykjGRtWSopxGTxE1mJcu HHQ9xpVjZDcBliTzDbQK60kmp/mNqmC4NnuIiO+M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lu Baolu , Joerg Roedel , Sasha Levin Subject: [PATCH 5.12 494/677] iommu/vt-d: Report the right page fault address Date: Wed, 12 May 2021 16:49:00 +0200 Message-Id: <20210512144853.797596198@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lu Baolu [ Upstream commit 03d205094af45bca4f8e0498c461a893aa3ec6d9 ] The Address field of the Page Request Descriptor only keeps bit [63:12] of the offending address. Convert it to a full address before reporting it to device drivers. Fixes: eb8d93ea3c1d3 ("iommu/vt-d: Report page request faults for guest SVA") Signed-off-by: Lu Baolu Link: https://lore.kernel.org/r/20210320025415.641201-2-baolu.lu@linux.intel.com Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/intel/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index 547a6cf57057..ecb6314fdd5c 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -862,7 +862,7 @@ intel_svm_prq_report(struct device *dev, struct page_req_dsc *desc) /* Fill in event data for device specific processing */ memset(&event, 0, sizeof(struct iommu_fault_event)); event.fault.type = IOMMU_FAULT_PAGE_REQ; - event.fault.prm.addr = desc->addr; + event.fault.prm.addr = (u64)desc->addr << VTD_PAGE_SHIFT; event.fault.prm.pasid = desc->pasid; event.fault.prm.grpid = desc->prg_index; event.fault.prm.perm = prq_to_iommu_prot(desc); -- 2.30.2