Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4744484pxj; Wed, 12 May 2021 12:13:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/ugR+Xgy4vjh8QecBb72tG337SA9JaRaNx777hA/gIVK73+3bRAS9X0IGy/pNs2XOTpNg X-Received: by 2002:a17:906:c453:: with SMTP id ck19mr40080080ejb.439.1620846791945; Wed, 12 May 2021 12:13:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620846791; cv=none; d=google.com; s=arc-20160816; b=TYBvwv7EVMCQhjt4xRsXI13ll4amx89sfU4vc7fhcyoOgBh28sOKETiPrEolN0g4VU CNkqUvZugAHqFc9W6CGAowpZs2Lvealxre5ibOgyGsRvlKEOmtaU3q2hfm3ry7vCuWKo KCu5Ix4WC69f3Kdo1r//azFDfAxyNlKrVzqjM+lNi39iM1Fb1JOhILD9pnLKOAiExv5x wK1hEvkNXYYQRSiPwwRk5+f1EZ3HwSdzt9MS0PKMFUjZY7cZfLUbaf5TfpsX0f7p7tqD VpsNzsekuoOeghySJiyRfZ/VGHrchRXPUImUVyA7p866l5HMHjBBnILmL1LWUfh/FUnx /++Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Z6H/JSBzmkx+Ybctr7+i/I9hhYLyE1JOC8+Lyrgf+44=; b=nbCvtlgix5AG5CJfBcNq9RVF6BJBghCPrDA3eAyilGy847PZWK32V30eD7ROEGXb+l kJMFdNJT1BnVqfAU1uSYhd+G4IRCJSBETJN7jX/pzFD0cizqhUiwb/CN/UHsJZzXtOvA 0azvDmg79gkRu1UgLal6glmWJ0rp7VXjijhrp8GYdgeK0ObBiLcpEE8KbC0gE4GqkAM2 7otldoTRbrZ9QdUGcEXCE4eshqB8ziASIVs57x9u4oG5cUeQo8s+hlMSBoihbo2BsKd4 1kLcJN3WEZh2+LDpEFlPXqA3pea+CHh5HBGgC7XiHFzALwCfOniE+FcZYNfOA+ysFkrn bQ2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZzqY83C5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si749754ejb.752.2021.05.12.12.12.46; Wed, 12 May 2021 12:13:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZzqY83C5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244154AbhELS6C (ORCPT + 99 others); Wed, 12 May 2021 14:58:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:56922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243308AbhELQhK (ORCPT ); Wed, 12 May 2021 12:37:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A0DD61E2F; Wed, 12 May 2021 16:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835341; bh=nTIRnDruiozt48EnkzzPMjoni5i2+tipW2+sdS0xD38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZzqY83C588ERPZvPzsAFrvHmv5/lyM6O5G81pdAdkn5KtczvAdeNOPmicmpiGaed3 Xu2K1xeH5dihio1LgzufalCh9N3pTNvZjOErryLX703OLOelYOX3DxKGXqRamo368o XftBZUNH5XSkj1Xwz4zUFMG8uvzM7eQ6eoYs3MOM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Sasha Levin Subject: [PATCH 5.12 298/677] usb: gadget: r8a66597: Add missing null check on return from platform_get_resource Date: Wed, 12 May 2021 16:45:44 +0200 Message-Id: <20210512144847.111203329@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit 9c2076090c2815fe7c49676df68dde7e60a9b9fc ] The call to platform_get_resource can potentially return a NULL pointer on failure, so add this check and return -EINVAL if it fails. Fixes: c41442474a26 ("usb: gadget: R8A66597 peripheral controller support.") Signed-off-by: Colin Ian King Addresses-Coverity: ("Dereference null return") Link: https://lore.kernel.org/r/20210406184510.433497-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/r8a66597-udc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c index 896c1a016d55..65cae4883454 100644 --- a/drivers/usb/gadget/udc/r8a66597-udc.c +++ b/drivers/usb/gadget/udc/r8a66597-udc.c @@ -1849,6 +1849,8 @@ static int r8a66597_probe(struct platform_device *pdev) return PTR_ERR(reg); ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + if (!ires) + return -EINVAL; irq = ires->start; irq_trigger = ires->flags & IRQF_TRIGGER_MASK; -- 2.30.2