Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4748879pxj; Wed, 12 May 2021 12:19:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZtgKaIiCvbMWD3tQQAOyPtwnTVBunuQhPDnPAYEfLPu4fxOn0iWTvo7LVf846SnjV8HAP X-Received: by 2002:a05:6402:5a:: with SMTP id f26mr45427502edu.306.1620847194716; Wed, 12 May 2021 12:19:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620847194; cv=none; d=google.com; s=arc-20160816; b=dhpBnHAow9glKHi2vYKYQTRRCYaT+7jCEa6Frd+9diEDKouS9XeVdluMZaqLmQDkCg K2wgNPnDxFDgD3BVsCbYe/VQCMMgj6+j/pR5tn5GBDLCZHEsf4+n/GeCdcHiY7xPgMYX TOTy5dhABT0/n2bGjqJUVy7tAwE23StGSeM6vQVRcsI2JYIOHASmS1kOxdRjw7H7IqJ7 2Mpc+bIQY3RBk5NGbOdnG/rPHAcju9CfnlKlmviA5DGe/O37SCO1RGh2wBfzN1O+tT3A vqgBWgVn1keZFNWfBG4aOIw0h0Yt/A1tFwmoMcFOCbZvNvTvpeUTt+SeRT7p1sqGpxYc R3yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BuyHuNQl7wXPZ2eOoDa8nBdWwi/2v6QzM1mvsh9sRys=; b=M54b9Yu3ZutMaUiWuXJ/INjG/Gb2cn/Ni/V0OCtnNq0VqoegpeY/YYzNxHP4FJ9Kzu UbHZmmWdYiNIoTvBUy1hDeLQZ37GGnOznO5stbt6OMIqxcsD2ctEHxfsquY3kSslEQg1 7Ggn0mP+vh7l/8mrJCfhy4CdPmejwOQJHPmFzUFGckl9zMTydI2b2HNzPIgpwZwh8Akp bnHPcT58k51GIIQh9CcOsGVGzro7Nws4toFIY4xM3XZ0PbXh9NL7Y0mfaGaKCkIu4Voo X34l7wqhe6xM7ATmStQCCweO9zDXHSZvMIQBZjjO4ILiXmnQ7RfbnP1ZVF2XBPcKk0rN RUzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WnlrjJwe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d23si610127ejz.732.2021.05.12.12.19.27; Wed, 12 May 2021 12:19:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WnlrjJwe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243970AbhELTAV (ORCPT + 99 others); Wed, 12 May 2021 15:00:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:33526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243579AbhELQlf (ORCPT ); Wed, 12 May 2021 12:41:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C94EB6143D; Wed, 12 May 2021 16:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835505; bh=+KpyCjVckXd3UguHZZZM+4+uIjQGnKRCcct75gRcjXM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WnlrjJweUJf0b6buofDJw2/BnIlyA7UIaOWF4q1zrR6XhHYVn7bld3z9fgxpLEPyA TJNDwZBqPgLFqGXoBESa5kZznD/nljiskLLsoq8jC8iDeszLyO7ldsEoYAWTZPqLZN W92ezyjcaaDTHuXMuple/F2ruEXuWpCc/k3e1cIg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Sasha Levin Subject: [PATCH 5.12 370/677] drm/amdkfd: Fix recursive lock warnings Date: Wed, 12 May 2021 16:46:56 +0200 Message-Id: <20210512144849.615096803@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Felix Kuehling [ Upstream commit 7816e4a98ce3bc7c562807240b4f14171e177420 ] memalloc_nofs_save/restore are no longer sufficient to prevent recursive lock warnings when holding locks that can be taken in MMU notifiers. Use memalloc_noreclaim_save/restore instead. Fixes: f920e413ff9c ("mm: track mmu notifiers in fs_reclaim_acquire/release") Signed-off-by: Felix Kuehling Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index adbfd1d227a5..a566bbe26bdd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -92,13 +92,13 @@ struct amdgpu_prt_cb { static inline void amdgpu_vm_eviction_lock(struct amdgpu_vm *vm) { mutex_lock(&vm->eviction_lock); - vm->saved_flags = memalloc_nofs_save(); + vm->saved_flags = memalloc_noreclaim_save(); } static inline int amdgpu_vm_eviction_trylock(struct amdgpu_vm *vm) { if (mutex_trylock(&vm->eviction_lock)) { - vm->saved_flags = memalloc_nofs_save(); + vm->saved_flags = memalloc_noreclaim_save(); return 1; } return 0; @@ -106,7 +106,7 @@ static inline int amdgpu_vm_eviction_trylock(struct amdgpu_vm *vm) static inline void amdgpu_vm_eviction_unlock(struct amdgpu_vm *vm) { - memalloc_nofs_restore(vm->saved_flags); + memalloc_noreclaim_restore(vm->saved_flags); mutex_unlock(&vm->eviction_lock); } -- 2.30.2