Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 02/15] misc: nnpi: Initialize NNP-I framework and PCIe
 modules
To:     Guy Zadicario <guy.zadicario@intel.com>,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc:     olof@lixom.net, alexander.shishkin@linux.intel.com,
        andriy.shevchenko@intel.com, yochai.shefi-simchon@intel.com
References: <20210512071046.34941-1-guy.zadicario@intel.com>
 <20210512071046.34941-3-guy.zadicario@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <fec29580-b5b3-3e62-05b2-0227de43971d@infradead.org>
Date:   Wed, 12 May 2021 11:07:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210512071046.34941-3-guy.zadicario@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/12/21 12:10 AM, Guy Zadicario wrote:
> diff --git a/drivers/misc/intel-nnpi/Kconfig b/drivers/misc/intel-nnpi/Kconfig
> new file mode 100644
> index 0000000..ccd39df
> --- /dev/null
> +++ b/drivers/misc/intel-nnpi/Kconfig
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +#
> +# Copyright (C) 2019-2021 Intel Corporation
> +#
> +#
> +
> +config INTEL_NNPI
> +	tristate "Intel(R) PCIe NNP-I (AI accelerator for inference) device driver"
> +	depends on PCI
> +	select DMA_SHARED_BUFFER
> +	help
> +	  Device driver for Intel NNP-I PCIe accelerator card for AI inference.
> +
> +	  If unsure, say N.
> +
> +	  To compile this driver as a module, choose M here. Two modules will
> +          get generated intel_nnpi and intel_nnpi_pcie.

For the last help text line, use a tab + 2 spaces for indentation.
Also 2 more changes:  s/get generated/be generated:/


thanks.
-- 
~Randy