Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4791858pxj; Wed, 12 May 2021 13:23:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmNFROqZX4Ii2erQ3MrCyrULfVvKEd03ZXw8dnkvWTSU/9a8aWUTX46YSPIVjW/q8dfWIS X-Received: by 2002:a4a:e385:: with SMTP id l5mr29207278oov.48.1620851010698; Wed, 12 May 2021 13:23:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620851010; cv=none; d=google.com; s=arc-20160816; b=FKgREFV+Kwt7WwBeucNuy67pEe2Ger7IAHLFXrpryx+BMnCeOoSVyUDu3VISQKfXNS pKETE+GAFOWGj7SLU20x+/lw4ZCHWa9YYKq2m5x6uFaGfhEBl7hDIw4mSO9UZiU/wWzE GDQhClUDPndoyLg0c0tucI4GeDc3QzkSl/ys4FGL+5ThfVgq6kRBvfIee9WFyfpCKTtu OqVVM3/pyQ3JxJB8qpeObln+V1h0W3tO7OoCmDQENA/MXIcyutoN5hA+yKc3NZjGZNQJ 3TbWuYP5E8M+qw1B0MsjWDsDGpw3zowL5BEo/TtjQxy2vAmieJBF6mP9Xh/Mu6gMaai6 eLjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8E+f2v9QvhbBgVYDW+xO78Asl5jNnBHA79MzCC/Nhas=; b=TA7LQr9pMADjYlJRr+kzN/1szIB97by74a3KX9bxPTfcTouoJ7ApMOfxinNwBcaCmh rb58rSv1ptcnekfRKxrh/o6gsfKeK/u+uNbUCvoHtxYJkMk1CHl5HI3zNhJq3+FdIDX+ 7a46BnnGnQ22TwbXq7gY6i9ryRhu0UrHxFk8wckscBDX5AvqqiyZ96JwRlQrx13IqEPQ Ty5zl+M+P52Dq/YQHl0BHamxCLpnbDNZJkkkc3eqNVswGQRLqy52McpcHAro1OgzVTv0 +FJKncu9aS1zgLgzsfODvhzhZryqjV/G3bViOgeQeLAATcFIYWp7OedbL9qtjgXyWHkY fR+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J7bDw0Gb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y82si847817oig.14.2021.05.12.13.23.16; Wed, 12 May 2021 13:23:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J7bDw0Gb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384862AbhELUC3 (ORCPT + 99 others); Wed, 12 May 2021 16:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355432AbhELSt0 (ORCPT ); Wed, 12 May 2021 14:49:26 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98B0DC06138A for ; Wed, 12 May 2021 11:45:08 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id t21so12987731plo.2 for ; Wed, 12 May 2021 11:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8E+f2v9QvhbBgVYDW+xO78Asl5jNnBHA79MzCC/Nhas=; b=J7bDw0Gb42knuv/5bGWUha8tmHo/XAaKNe92liTG6ZQwgtbmUqSHXcAo62HQMUsj2m /o0PlQXpwrRKXe6ZwQaDyYQaps2WtGJO7qg34HTldk8NJf672Yy1K5M8qWfNK6rQTGva ked/2CiwoZxYMIV5gUtUOEL+MmwD7bfaVGx11T63lBtNp9AOjiJFpsNT5ln8ycfbWLu6 3w+Zr+bIT8wjOu0FdtCPYjZrQ58AfxbcYzahN4/IoE10ZrR0EPoXQmye1K5r+gw/QOWe VT4J7eyU5ILGajWs9sSmpcYikLltLV+Xbnem9ZhEyPOmxEDEve6TrSuroGsBdQATPl9r lJ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8E+f2v9QvhbBgVYDW+xO78Asl5jNnBHA79MzCC/Nhas=; b=RMg3J8uTnTF39pXopvzGlc2jge6YVaLIfYb0NQ7b+PDsi3tgcx9QOeeHaVIs6vKoXc CJAUacu/o/7HQ0FZEERR97Dy56BXLPMEqxxTmzkzTwfn+ujietJkTqMrmua/Qc1fzdT2 zuC7GsSbEnGG72TG9tjAuXwwsuxNlziKm78XPlvRXnHlF95M1Dernkyib7aLVENbZIMg fIHpcoKqPgK/7sDtwB6IP5bcUD8vZEIS5Bxd9ciPNmPOJN8TxCMyHWSQRRV9g4U3TOjj LJTQBERFuGMhagS7JXRRLu6lGIKOla5gxc322aKw92a2idShKHfJqOuHBFVdg1kxTLmJ oBFw== X-Gm-Message-State: AOAM531CoDqRtlYli7Lgr/62fCYDDsHILQ4BgofewTiTcIam4Lij4tFV SGpz+04N+9GfLTlHDMZeKrI= X-Received: by 2002:a17:902:4:b029:ee:8f40:ecbf with SMTP id 4-20020a1709020004b02900ee8f40ecbfmr35791300pla.28.1620845108131; Wed, 12 May 2021 11:45:08 -0700 (PDT) Received: from localhost.localdomain ([118.200.63.8]) by smtp.gmail.com with ESMTPSA id i8sm367165pjs.54.2021.05.12.11.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 11:45:07 -0700 (PDT) From: Nguyen Dinh Phi To: nsaenz@kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, amarjargal16@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] Staging: vchiq_arm: Using pr_err and pr_notice instead of printk Date: Thu, 13 May 2021 02:44:40 +0800 Message-Id: <20210512184440.550116-1-phind.uet@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the following checkpatch.pl warning: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Nguyen Dinh Phi --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 1b1356833b8f..ee759cb786b0 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -2192,10 +2192,10 @@ vchiq_get_state(void) { if (!g_state.remote) - printk(KERN_ERR "%s: g_state.remote == NULL\n", __func__); + pr_err("%s: g_state.remote == NULL\n", __func__); else if (g_state.remote->initialised != 1) - printk(KERN_NOTICE "%s: g_state.remote->initialised != 1 (%d)\n", - __func__, g_state.remote->initialised); + pr_notice("%s: g_state.remote->initialised != 1 (%d)\n", + __func__, g_state.remote->initialised); return (g_state.remote && (g_state.remote->initialised == 1)) ? &g_state : NULL; -- 2.25.1