Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)
To:     Daniel Borkmann <daniel@iogearbox.net>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>
References: <20210512175623.2687ac6f@canb.auug.org.au>
 <08f677a5-7634-b5d2-a532-ea6d3f35200c@infradead.org>
 <daf46ee7-1a18-9d5a-c3b3-7fc55ec23b30@iogearbox.net>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <751025d2-9c46-a4b9-4f54-fbe5fa7a2564@infradead.org>
Date:   Wed, 12 May 2021 12:26:11 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <daf46ee7-1a18-9d5a-c3b3-7fc55ec23b30@iogearbox.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/12/21 11:53 AM, Daniel Borkmann wrote:
> Hi Randy,
> 
> On 5/12/21 8:01 PM, Randy Dunlap wrote:
>> On 5/12/21 12:56 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210511:
>>>
>>
>> on i386:
>>
>> ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
>> bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
>> ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
>> bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
>> ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
>> ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
>> ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
>> ld: kernel/extable.o: in function `search_exception_tables':
>> extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
>> ld: kernel/extable.o: in function `kernel_text_address':
>> extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
>> kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
>> kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'
> 
> Thanks for reporting, could you double check the following diff:
> 
> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
> index 26b591e23f16..bd04f4a44c01 100644
> --- a/kernel/bpf/Kconfig
> +++ b/kernel/bpf/Kconfig
> @@ -37,6 +37,7 @@ config BPF_SYSCALL
> 
> config BPF_JIT
>     bool "Enable BPF Just In Time compiler"
> +    depends on BPF
>     depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
>     depends on MODULES
>     help

That's good. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


-- 
~Randy