Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 May 2021 22:14:54 +0200
From:   Corentin Labbe <clabbe.montjoie@gmail.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Hans Ulli Kroll <ulli.kroll@googlemail.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: gemini: sl3516: Mainlining of NS 2502
Message-ID: <YJw3PrZqz2q5OYbI@Red>
References: <YGtZeofmBv7hXK+a@Red>
 <CACRpkdZ_barDrLvD2UBKo+GA-F+g72uMQx8CfRK2YLRodpeyUA@mail.gmail.com>
 <YGxOf8pKN8Ip/kCl@Red>
 <CACRpkdYRUXJY_tXamS0vc+RNPDxR2oxdRLbBUk0fmQLp+eYAOA@mail.gmail.com>
 <YJLxTgVflotKs5Oe@Red>
 <CACRpkdaGAiK57LE8vkEBjCGwb+HRWBzWS_C86xdNa8N51G+1PA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdaGAiK57LE8vkEBjCGwb+HRWBzWS_C86xdNa8N51G+1PA@mail.gmail.com>
Precedence: bulk

Le Thu, May 06, 2021 at 01:56:28AM +0200, Linus Walleij a ?crit :
> Hi Corentin,
> 
> I will check the patches you posted too, sorry for being a bit busy
> with some merge window and stuff.
> 
> On Wed, May 5, 2021 at 9:26 PM Corentin Labbe <clabbe.montjoie@gmail.com> wrote:
> 
> > It seems that USB is still a bit buggy, device are detected only if plugged before boot.
> 
> Yeah :/ I don't know that driver very well, only that others use it too
> so there might be some people who can help. I haven't mainlined
> that patch because there is something that seems wrong about it
> but I'm not a USB guy.
> 
> > I hit a problem on the NS2502, sata drives does not work well:
> (...)
> > It seems a problem soon after driver probe (qc timeout and HPA error).
> > Any idea ?
> >
> > The SATA works well on my other board (SSI1328)
> > having one or two disk does not change the behavour.
> 
> Could be the SATA muxing, this thing in your device tree:
> 
> sata: sata@46000000 {
>     cortina,gemini-ata-muxmode = <0>;
>     cortina,gemini-enable-sata-bridge;
>     status = "okay";
> };
> 
> cortina,gemini-ata-muxmode should be 3 for two harddisks
> I think.
> 

I used 0, and only the second slot was working.
Using 3 fixed both slots.

Thanks