Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4875895pxj; Wed, 12 May 2021 15:24:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQSUYaOoitrDhWXCW2Tnc5nmhw8V9Zt3i7XCjp56JTtA21PLom7vdjT8jbu7DYYSUJaOvl X-Received: by 2002:a17:906:2c55:: with SMTP id f21mr41255676ejh.41.1620858295461; Wed, 12 May 2021 15:24:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620858295; cv=none; d=google.com; s=arc-20160816; b=ErOJPSm0OBdCFbAmTt68XvIjo+B3wxLy67jUstg7pBOToBIYEIL1yrvKWVTqtQnJtR weihPMLzxyXx7BZLwcBdYi3I3gfYhAKSLq8Y9dmnf5dQ91h95JWQ5FrOEdE1XCWW9jg7 kGlAqRfKDH44OUwA73LncnNpejnPeAGKd9hmJJ4b+tXYoUa1fuSQ+Le81bGGYgsVzlR5 NReo0wmdhYzd0cXiC49d89bOxBh91o/AJsR0CaMTnhwb6RLSpCjuYNlbJnekNYxudImN OoXXF57fu9ty2hHXZJQHCYKzxgCWamr7mWb7QgpI2YZYi8ejUEXD6UtX0IWPJnADGXOp OkZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ERc410jQoRzw3yzM59tPDqglVXoV82EK4yH1wKW1SpI=; b=SvquiJqouBiS4JtMdmCehUobn7wRQGvMXRCLGKwyb360g9lv1pMnDnJu0xZrxkc/o6 JawEIxvNOt1/h7KASRaDgHkMYfynfGQJyIAJK+TqCW9HFuNVjvXssLrzNddPX1PzmKtj mdo6S7OULtaAO2EGysPF1cXpnBwgJzF8v1UOT1lGK4vLafa5592AgYMiaK1laMLM0qFc PTB74lpz4H/LmC39JoXEETDON4CwSXxGtUIvLn88cNKVSBZJOgbs5wuQG5PAmYu9o1tL Nl+mjJTjLEZXM6wbApHqCr2KEXAM8AXTJZXUe0eyggHtlChDbSgt7QXwYFuU8Fc8zYJ6 6/6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u16si1390789eje.499.2021.05.12.15.24.31; Wed, 12 May 2021 15:24:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443131AbhELWQ1 (ORCPT + 99 others); Wed, 12 May 2021 18:16:27 -0400 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:39477 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1392187AbhELVgv (ORCPT ); Wed, 12 May 2021 17:36:51 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d61 with ME id 3xbe2500821Fzsu03xbe13; Wed, 12 May 2021 23:35:41 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 12 May 2021 23:35:41 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, david.daney@cavium.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] net: mdio: Fix a double free issue in the .remove function Date: Wed, 12 May 2021 23:35:38 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'bus->mii_bus' have been allocated with 'devm_mdiobus_alloc_size()' in the probe function. So it must not be freed explicitly or there will be a double free. Remove the incorrect 'mdiobus_free' in the remove function. Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.") Signed-off-by: Christophe JAILLET --- drivers/net/mdio/mdio-thunder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mdio/mdio-thunder.c b/drivers/net/mdio/mdio-thunder.c index cb1761693b69..822d2cdd2f35 100644 --- a/drivers/net/mdio/mdio-thunder.c +++ b/drivers/net/mdio/mdio-thunder.c @@ -126,7 +126,6 @@ static void thunder_mdiobus_pci_remove(struct pci_dev *pdev) continue; mdiobus_unregister(bus->mii_bus); - mdiobus_free(bus->mii_bus); oct_mdio_writeq(0, bus->register_base + SMI_EN); } pci_release_regions(pdev); -- 2.30.2