Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4955155pxj; Wed, 12 May 2021 17:39:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGEQFRvEkwyMx7WI1vLTScIKowJP0ja7gUSzzZ9Pvsl7UAdPoXPJBUf38Hukczp0lqXXWo X-Received: by 2002:a17:906:b0cb:: with SMTP id bk11mr41308258ejb.310.1620866358636; Wed, 12 May 2021 17:39:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620866358; cv=none; d=google.com; s=arc-20160816; b=NxnqOrHtoZ5wk08gwW/alhhUKKiJjJXUrvF5dFmGSmKuLRJodp36KXf90ARGuHRaBq QZ6rucu3Y5TmX+Zfm0spZPjNHbHApB8hiCBNymvS5r6A/XTkPAmv+8psNyu+7LoNHbfo GNt52UhDpH0g8/Q/N/NFQQH1tI+LLmGqF4H5n/RPVRLQ3+THCKcOdpJtUAMm5PfzoQjB BxDeJGmKKtsN8tLL5Qa1bwGDD2jxJ87haTR10Qah28tDhPVeUirgYvd9LkAGz/PEMZhY VPyH5OTIWHHRk5i8VXoUCUIRe0PzYd5lrKKlmPPeG7b6aFUUJ59VlEsxIeNyrUfvx0DY H27A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YQuBY74AYh2bwOk1pzi5wapZwac9JgQFOETRxsoeeLQ=; b=K+i/4FUpkJ9i8kEPyElMqC462NzwPL5bI6XF9QVogy1XOIesHNZV9WmZlzQqU/hTSf 29igPFJzeX+TkyqRKC6KdmrNXFbhCA2yh7geJ2deWh0hhHn2SnlBiEpST+Igs3DoRFkU rl9T98FM1a96UBPSdBw7grcoR1BUV8Bc4VwsM9ajvoUd//WjH2tx52oN1kh3kumN2mnr hVhOkSufccT55Adl8Ljw8PltserWQTfDZPY/q01HurZo3BQvN4YiTS8tEqeBgUvkhceY YHRPK6bKQFKnItH2YEG9HUc/5uxQ3S7j55iSQ5gvwNG/Idsba5OA3QH4NTjD1VDx2uUB RDaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w69tGANK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si1392950ejj.154.2021.05.12.17.38.55; Wed, 12 May 2021 17:39:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w69tGANK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237750AbhELP4T (ORCPT + 99 others); Wed, 12 May 2021 11:56:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235154AbhELP04 (ORCPT ); Wed, 12 May 2021 11:26:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0026961A33; Wed, 12 May 2021 15:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620832317; bh=jjUBIP4SiM0ATLRglWSDxzYDel7xBraSSOu2ZrBNxoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w69tGANKLBF5V7Xvjb4WIxxNp+uVitaCPbf8zeN9YUujn9nucoCTJqUeOAHOvyx2Z MjMjq+qJFK6VbpP8oVtq1iDSzhvQvJdl6xkpq4hJiimR6Di18FzaJsATgPZ8/WGtwX 2rvGYW2rtnEauNilv16BDspPZasTSoRifpKQ1WgA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= , Stephen Boyd , Gregory CLEMENT , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , Viresh Kumar , Sasha Levin Subject: [PATCH 5.10 231/530] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock Date: Wed, 12 May 2021 16:45:41 +0200 Message-Id: <20210512144827.427492549@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144819.664462530@linuxfoundation.org> References: <20210512144819.664462530@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Behún [ Upstream commit 4e435a9dd26c46ac018997cc0562d50b1a96f372 ] Remove the .set_parent method in clk_pm_cpu_ops. This method was supposed to be needed by the armada-37xx-cpufreq driver, but was never actually called due to wrong assumptions in the cpufreq driver. After this was fixed in the cpufreq driver, this method is not needed anymore. Signed-off-by: Marek Behún Acked-by: Stephen Boyd Acked-by: Gregory CLEMENT Tested-by: Pali Rohár Tested-by: Tomasz Maciej Nowak Tested-by: Anders Trier Olesen Tested-by: Philip Soares Fixes: 2089dc33ea0e ("clk: mvebu: armada-37xx-periph: add DVFS support for cpu clocks") Signed-off-by: Viresh Kumar Signed-off-by: Sasha Levin --- drivers/clk/mvebu/armada-37xx-periph.c | 28 -------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c index f5746f9ea929..6507bd2c5f31 100644 --- a/drivers/clk/mvebu/armada-37xx-periph.c +++ b/drivers/clk/mvebu/armada-37xx-periph.c @@ -440,33 +440,6 @@ static u8 clk_pm_cpu_get_parent(struct clk_hw *hw) return val; } -static int clk_pm_cpu_set_parent(struct clk_hw *hw, u8 index) -{ - struct clk_pm_cpu *pm_cpu = to_clk_pm_cpu(hw); - struct regmap *base = pm_cpu->nb_pm_base; - int load_level; - - /* - * We set the clock parent only if the DVFS is available but - * not enabled. - */ - if (IS_ERR(base) || armada_3700_pm_dvfs_is_enabled(base)) - return -EINVAL; - - /* Set the parent clock for all the load level */ - for (load_level = 0; load_level < LOAD_LEVEL_NR; load_level++) { - unsigned int reg, mask, val, - offset = ARMADA_37XX_NB_TBG_SEL_OFF; - - armada_3700_pm_dvfs_update_regs(load_level, ®, &offset); - - val = index << offset; - mask = ARMADA_37XX_NB_TBG_SEL_MASK << offset; - regmap_update_bits(base, reg, mask, val); - } - return 0; -} - static unsigned long clk_pm_cpu_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) { @@ -592,7 +565,6 @@ static int clk_pm_cpu_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops clk_pm_cpu_ops = { .get_parent = clk_pm_cpu_get_parent, - .set_parent = clk_pm_cpu_set_parent, .round_rate = clk_pm_cpu_round_rate, .set_rate = clk_pm_cpu_set_rate, .recalc_rate = clk_pm_cpu_recalc_rate, -- 2.30.2