Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        wim@linux-watchdog.org
Cc:     p.zabel@pengutronix.de, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1620871503-100900-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <b885c7ac-2e25-6a03-4434-d0b31f92a15a@roeck-us.net>
Date:   Wed, 12 May 2021 20:15:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <1620871503-100900-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/12/21 7:05 PM, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
> 
> ./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/watchdog/dw_wdt.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e17..b1642e2 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
>   #include <linux/delay.h>
>   #include <linux/err.h>
>   #include <linux/io.h>
> -#include <linux/kernel.h>
>   #include <linux/module.h>
>   #include <linux/moduleparam.h>
>   #include <linux/interrupt.h>
> 

When making such changes, please use the opportunity to reorder include files
in alphabetic order to help ensure that duplicate includes don't happen again.

Thanks,
Guenter