Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-448-gae190416c7-fm-20210505.004-gae190416
Mime-Version: 1.0
Message-Id: <1ffffb47-4846-4769-910f-6606a1364a74@www.fastmail.com>
In-Reply-To: <20210429205002.70245-3-eajames@linux.ibm.com>
References: <20210429205002.70245-1-eajames@linux.ibm.com>
 <20210429205002.70245-3-eajames@linux.ibm.com>
Date:   Thu, 13 May 2021 14:21:32 +0930
From:   "Andrew Jeffery" <andrew@aj.id.au>
To:     "Eddie James" <eajames@linux.ibm.com>, linux-leds@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, "Pavel Machek" <pavel@ucw.cz>,
        "Jacek Anaszewski" <jacek.anaszewski@gmail.com>, robh+dt@kernel.or,
        devicetree@vger.kernel.org, vishwa@linux.ibm.com
Subject: =?UTF-8?Q?Re:_[PATCH_2/5]_leds:_leds-core:_Implement_the_retain-state-sh?=
 =?UTF-8?Q?utdown_property?=
Content-Type: text/plain
Precedence: bulk


On Fri, 30 Apr 2021, at 06:19, Eddie James wrote:
> Read the retain-state-shutdown device tree property to set the
> existing LED_RETAIN_AT_SHUTDOWN flag. Then check the flag when
> unregistering, and if set, don't set the brightness to OFF. This
> is useful for systems that want to keep the HW state of the LED
> across reboots.
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
>  drivers/leds/led-class.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 2e495ff67856..f2f29318d312 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -354,10 +354,15 @@ int led_classdev_register_ext(struct device *parent,
>  		if (ret < 0)
>  			return ret;
>  
> -		if (init_data->fwnode)
> +		if (init_data->fwnode) {
>  			fwnode_property_read_string(init_data->fwnode,
>  				"linux,default-trigger",
>  				&led_cdev->default_trigger);
> +
> +			if (fwnode_property_present(init_data->fwnode,
> +						    "retain-state-shutdown"))
> +				led_cdev->flags |= LED_RETAIN_AT_SHUTDOWN;

This is what we need, but I notice the pca955x driver is calling 
through devm_led_classdev_register() which passes NULL through 
init_data. So we won't get the result we want from this series as I 
understand it.

Andrew