Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 04/12] iio: adc: ad7192: handle zero Avdd regulator
 value
To:     Alexandru Ardelean <aardelean@deviqon.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     jic23@kernel.org, Jonathan.Cameron@huawei.com,
        alexandru.tachici@analog.com, linux@deviqon.com
References: <20210512174914.10549-1-aardelean@deviqon.com>
 <20210512174914.10549-5-aardelean@deviqon.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <46a03414-0ead-46a1-f0fe-20f1c22a70b5@metafoo.de>
Date:   Thu, 13 May 2021 09:41:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210512174914.10549-5-aardelean@deviqon.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 5/12/21 7:49 PM, Alexandru Ardelean wrote:
> This change fixes a corner-case, where for a zero regulator value, the
> driver would exit early, initializing the driver only partially.
> The driver would be in an unknown state.
>
> If the regulator value is zero, then the internal reference will be zero
> (though that value will be zero for anything less than 1 millivolt).
>
> Fixes: ab0afa65bbc7 ("staging: iio: adc: ad7192: fail probe on get_voltage")
> Cc: Alexandru Tachici <alexandru.tachici@analog.com>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>   drivers/iio/adc/ad7192.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index d3be67aa0522..9da394ad3868 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -951,7 +951,7 @@ static int ad7192_probe(struct spi_device *spi)
>   
>   	voltage_uv = regulator_get_voltage(st->avdd);
>   
> -	if (voltage_uv > 0) {
> +	if (voltage_uv >= 0) {
>   		st->int_vref_mv = voltage_uv / 1000;
>   	} else {
>   		ret = voltage_uv;

More idiomatic would be to check for voltage_uv < 0.

     if (voltage_uv < 0) {
         ret = voltage_uv;
         dev_err(&spi->dev, "Device tree error, reference voltage 
undefined\n");
         goto error_disable_avdd;
     }

     st->int_vref_mv = voltage_uv / 1000;