Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE
To:     Zou Wei <zou_wei@huawei.com>, <thierry.reding@gmail.com>,
        <lorenzo.pieralisi@arm.com>, <robh@kernel.org>,
        <bhelgaas@google.com>, <jonathanh@nvidia.com>
CC:     <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1620792422-16535-1-git-send-email-zou_wei@huawei.com>
From:   Vidya Sagar <vidyas@nvidia.com>
Message-ID: <241d64eb-44e4-a838-a07a-8127c189a1c1@nvidia.com>
Date:   Thu, 13 May 2021 14:28:33 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <1620792422-16535-1-git-send-email-zou_wei@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2021 08:58:38.5198
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dfac91a3-78a1-402f-0c98-08d915ed4c9b
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT023.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0146
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for the patch.

Reviewed-by: Vidya Sagar <vidyas@nvidia.com>

On 5/12/2021 9:37 AM, Zou Wei wrote:
> External email: Use caution opening links or attachments
> 
> 
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>   drivers/pci/controller/pci-tegra.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 8069bd9..c979229 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2539,6 +2539,7 @@ static const struct of_device_id tegra_pcie_of_match[] = {
>          { .compatible = "nvidia,tegra20-pcie", .data = &tegra20_pcie },
>          { },
>   };
> +MODULE_DEVICE_TABLE(of, tegra_pcie_of_match);
> 
>   static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
>   {
> --
> 2.6.2
>