Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210512174914.10549-1-aardelean@deviqon.com> <20210512174914.10549-5-aardelean@deviqon.com>
 <46a03414-0ead-46a1-f0fe-20f1c22a70b5@metafoo.de>
In-Reply-To: <46a03414-0ead-46a1-f0fe-20f1c22a70b5@metafoo.de>
From:   Alexandru Ardelean <ardeleanalex@gmail.com>
Date:   Thu, 13 May 2021 12:11:46 +0300
Message-ID: <CA+U=DspWZNKT8M+Qa7oR_sBBMX04MaQ1K_xKq68WKwtPeQ8D1Q@mail.gmail.com>
Subject: Re: [PATCH v3 04/12] iio: adc: ad7192: handle zero Avdd regulator value
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Alexandru Ardelean <aardelean@deviqon.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Alexandru Tachici <alexandru.tachici@analog.com>,
        linux@deviqon.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 13, 2021 at 10:43 AM Lars-Peter Clausen <lars@metafoo.de> wrote:
>
> On 5/12/21 7:49 PM, Alexandru Ardelean wrote:
> > This change fixes a corner-case, where for a zero regulator value, the
> > driver would exit early, initializing the driver only partially.
> > The driver would be in an unknown state.
> >
> > If the regulator value is zero, then the internal reference will be zero
> > (though that value will be zero for anything less than 1 millivolt).
> >
> > Fixes: ab0afa65bbc7 ("staging: iio: adc: ad7192: fail probe on get_voltage")
> > Cc: Alexandru Tachici <alexandru.tachici@analog.com>
> > Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> > ---
> >   drivers/iio/adc/ad7192.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> > index d3be67aa0522..9da394ad3868 100644
> > --- a/drivers/iio/adc/ad7192.c
> > +++ b/drivers/iio/adc/ad7192.c
> > @@ -951,7 +951,7 @@ static int ad7192_probe(struct spi_device *spi)
> >
> >       voltage_uv = regulator_get_voltage(st->avdd);
> >
> > -     if (voltage_uv > 0) {
> > +     if (voltage_uv >= 0) {
> >               st->int_vref_mv = voltage_uv / 1000;
> >       } else {
> >               ret = voltage_uv;
>
> More idiomatic would be to check for voltage_uv < 0.

sure;
makes sense
will re-spin

>
>      if (voltage_uv < 0) {
>          ret = voltage_uv;
>          dev_err(&spi->dev, "Device tree error, reference voltage
> undefined\n");
>          goto error_disable_avdd;
>      }
>
>      st->int_vref_mv = voltage_uv / 1000;
>