Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210513051920.29320-1-rdunlap@infradead.org>
In-Reply-To: <20210513051920.29320-1-rdunlap@infradead.org>
From:   Oliver Glitta <glittao@gmail.com>
Date:   Thu, 13 May 2021 11:37:44 +0200
Message-ID: <CAD=R=qomoJW5jLNPWieKSCU1W=hM2dp2p1TJ-6a_DJhYmNaWQA@mail.gmail.com>
Subject: Re: [PATCH -mm] slub: STACKDEPOT: rename save_stack_trace()
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=C5=A1t 13. 5. 2021 o 7:19 Randy Dunlap <rdunlap@infradead.org> nap=C3=ADsa=
l(a):
>
> save_stack_trace() already exists, so change the one in
> CONFIG_STACKDEPOT to be save_stack_depot_trace().
>
> Fixes this build error:
>
> ../mm/slub.c:607:29: error: conflicting types for =E2=80=98save_stack_tra=
ce=E2=80=99
>  static depot_stack_handle_t save_stack_trace(gfp_t flags)
>                              ^~~~~~~~~~~~~~~~
> In file included from ../include/linux/page_ext.h:6:0,
>                  from ../include/linux/mm.h:25,
>                  from ../mm/slub.c:13:
> ../include/linux/stacktrace.h:86:13: note: previous declaration of =E2=80=
=98save_stack_trace=E2=80=99 was here
>  extern void save_stack_trace(struct stack_trace *trace);
>              ^~~~~~~~~~~~~~~~
>
> from this patch in mmotm:
>   Subject: mm/slub: use stackdepot to save stack trace in objects
>
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Oliver Glitta <glittao@gmail.com>

I run it with CONFIG_ARCH_STACKWALK set on, so it didn't show this error.
Thank you for your fix.

> Cc: Oliver Glitta <glittao@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> ---
>  mm/slub.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- mmotm-2021-0512-2146.orig/mm/slub.c
> +++ mmotm-2021-0512-2146/mm/slub.c
> @@ -604,7 +604,7 @@ static struct track *get_track(struct km
>  }
>
>  #ifdef CONFIG_STACKDEPOT
> -static depot_stack_handle_t save_stack_trace(gfp_t flags)
> +static depot_stack_handle_t save_stack_depot_trace(gfp_t flags)
>  {
>         unsigned long entries[TRACK_ADDRS_COUNT];
>         depot_stack_handle_t handle;
> @@ -623,7 +623,7 @@ static void set_track(struct kmem_cache
>
>         if (addr) {
>  #ifdef CONFIG_STACKDEPOT
> -               p->handle =3D save_stack_trace(GFP_KERNEL);
> +               p->handle =3D save_stack_depot_trace(GFP_KERNEL);
>  #endif
>                 p->addr =3D addr;
>                 p->cpu =3D smp_processor_id();