Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp257084pxj; Thu, 13 May 2021 04:20:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5hsvakVUpMeLCrvuG2vQayekLEceC/5RhXaF5NhkFCVTIq0epE5Dsz9QYHd/vADRHOwEf X-Received: by 2002:a05:6e02:58f:: with SMTP id c15mr37215809ils.277.1620904828765; Thu, 13 May 2021 04:20:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620904828; cv=none; d=google.com; s=arc-20160816; b=YVW6DRmZxbXOKT4kWQxIqG1Nj7ps7ntsfB2u8k7j9nY8hLDm5TWByGci/Z/F/7TGt+ P9QQDgVNtVZ4ijpdxwhwyD6dpl1oooQvvHI3tFZpbO1qizs22TSX0ecjKQ3se00YOf0G m7SOY4P/w1TwgXP7y/MRkGNt5nR5ykvmGr08YkX8Ym9hjZ9p68z37e1SxnWdr+J5umew jnwZkVApwDSGgzi8zEe3Xe+TcA5NSd+w3MqcIYFiSlldB5MUNx7OmSjFamZad1dnIKDY v9yuxpQjRK1HMeM37SnoPa4r5jGzv7r3YRn61ScvcoSTfq56gZlqRHvXJfZZaJgjfApz bSTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kMJdIeYGZFtZpiEQsToBY8vMShbMp4Z1xrALz2MtXJA=; b=Lujss9C8wrAXnoei8F+bGNiPoDaJ3XSE7meUTM3PB/1pprz2Vq8LjrdWCCJSRFeISV Fuz/RZFD/7+wXZYTEaca0lyvHZaHT7OcISAvKAmGjgcNpeFMJ0/QpvF/45Kjue/cwEbU BltGDAd3NhpOUnklkkGvLTnRE5zN/1QdLe2zuyJhUsGRZz7kOQeEX3I/VbuMluva4+F6 6502cfjxLC2tBYne8BAOunBHvThKjEfc/zETt0s3HAkYBYJoEnSJrxVBpCzkho3YVfD9 s38uso3WuqistbQ3sNtmcOt5EcdrFarLkihQFci2/NjXU7eYp6n3VeTjkEpraXkd/6lw 7QtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0bKc5x8K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m22si3319640jaj.54.2021.05.13.04.20.15; Thu, 13 May 2021 04:20:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0bKc5x8K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232067AbhEMJrb (ORCPT + 99 others); Thu, 13 May 2021 05:47:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:49336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbhEMJr2 (ORCPT ); Thu, 13 May 2021 05:47:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6ACFC61439; Thu, 13 May 2021 09:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620899178; bh=2YDPX0ZygP42OUgip4Dx4XOsWdN5W0wiW342gHSvIfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0bKc5x8KTUNZj8xk+2qm0hSx4ORSNFaMpnuyS+FE1DScC2cuH5bQjmEfqoJeZ7wOR 9O7vaiQ8l1QvMfqzwNlwGEN/mRYlGiKbfLf7m0FgrEdwW8Gbht1AngzYxGMXuNUhnu 6U4360c2l8oXK7OFWETybk5pIVIHwUIFNG6mirOE= Date: Thu, 13 May 2021 11:46:16 +0200 From: Greg KH To: Zou Wei Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] staging: greybus: audio: Add missing MODULE_DEVICE_TABLE Message-ID: References: <1620895772-52538-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620895772-52538-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 04:49:32PM +0800, Zou Wei wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > drivers/staging/greybus/audio_codec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c > index b589cf6..6fa9781 100644 > --- a/drivers/staging/greybus/audio_codec.c > +++ b/drivers/staging/greybus/audio_codec.c > @@ -1086,6 +1086,7 @@ static const struct of_device_id greybus_asoc_machine_of_match[] = { > { .compatible = "toshiba,apb-dummy-codec", }, > {}, > }; > +MODULE_DEVICE_TABLE(of, greybus_asoc_machine_of_match); > > static struct platform_driver gbaudio_codec_driver = { > .driver = { > -- > 2.6.2 > > I think I will just start rejecting all of thes "missing MODULE_DEVICE_TABLE()" patches as they make no sense at all. If the driver authors had wanted these MODULE_DEVICE_TABLES added, they would have done so. That means they were not using dynamically loaded modules because usually, the module is built in, OR it doesn't matter. So please, only add this if you have a system that needs them, do not add them just based on a rule you have generated by a tool, as that is pointless. thanks, greg k-h