Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp273355pxj; Thu, 13 May 2021 04:45:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZNRLpXO6w8uuzaQzbFJDnM0XtiH4w41nHMTI8XLEI98mlsS9kY4fDmEFYOMDPpyjgQW/m X-Received: by 2002:a05:6602:2e82:: with SMTP id m2mr28702712iow.190.1620906331647; Thu, 13 May 2021 04:45:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620906331; cv=none; d=google.com; s=arc-20160816; b=Php6BpLqMYDtaroW1Y9iT47QF9a+R0XIsWZFYv75yXcw2gbLpFIhXi4++0RVqW9+bf eC77+iGTiX8LahU1Foyv7VZesnLx0XGgo/5OO8Ci/2TAuR9XTPKLvYTenrIy91A+8Qzo wxPjUSps96hLphPfjdrAqhEOg3Dmg/DFdAOnmTthfNiG/DHL9dl/CRVpFhrXLFyCKemp JYC3pagRQTg1AtP+13jzxmfFWLHFhXChLZnD5BFSj6Mgd3b4uwFu1doviYUjCW9Xk5/i S14LivU/MyfxE4nTOZf+/Ngxoeo7a7GPR3z8ELvU4UGBxLRipKJMRh4j2q2oD63dxiRY 8crQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=7f/A+CaPLE1yYaCJiRzR8HJXx8mdHcnNoCaCy++xpBI=; b=BtaDvVD6Uf0oFAs5wTRJcR79cR3UTBlOy5Ni4+rC7B7az9fvoxCqamfjNygbroGVvC 74jzEiyxiQbJb71RbUjLLlq7lJGFmnSsXClQTs0SP7+1NQBdDYT8HJVLaoJdqSoKrogW zCnRgH5mZTdO+hq7iGICZqnFiMPku73BDn3618CSYAS6Um16jJKnGu8hSB6y55t/ExeP OwvwtbYQOWzCTOMTSjuTWmcrhCRzTJnX91W1/+WyRttUs2DSDNk9AQSuRbiSXWaS5aIN OTD12WLAns/EGEmc+cG7KM1MqmDDNP+AA3vlbPCEr/5J48j3VOsRsswLCYZEqZsIgedC OlJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s4si3260094ilp.142.2021.05.13.04.45.17; Thu, 13 May 2021 04:45:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232371AbhEMKvL (ORCPT + 99 others); Thu, 13 May 2021 06:51:11 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:51657 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232106AbhEMKu5 (ORCPT ); Thu, 13 May 2021 06:50:57 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UYk7jUl_1620902979; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UYk7jUl_1620902979) by smtp.aliyun-inc.com(127.0.0.1); Thu, 13 May 2021 18:49:45 +0800 From: Jiapeng Chong To: bootc@bootc.net Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] scsi: target: sbp_target: Remove redundant assignment to pg_size Date: Thu, 13 May 2021 18:49:37 +0800 Message-Id: <1620902977-57076-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable pg_size is set to '0x100 << pg_size', but this value is never read as it is not used later on, hence it is a redundant assignment and can be removed. Clean up the following clang-analyzer warning: drivers/target/sbp/sbp_target.c:1264:3: warning: Value stored to 'pg_size' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/target/sbp/sbp_target.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c index ce84f93..4d3ceee 100644 --- a/drivers/target/sbp/sbp_target.c +++ b/drivers/target/sbp/sbp_target.c @@ -1261,7 +1261,6 @@ static int sbp_rw_data(struct sbp_target_request *req) pg_size = CMDBLK_ORB_PG_SIZE(be32_to_cpu(req->orb.misc)); if (pg_size) { pr_err("sbp_run_transaction: page size ignored\n"); - pg_size = 0x100 << pg_size; } spin_lock_bh(&sess->lock); -- 1.8.3.1