Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH] perf cs-etm: Handle valid-but-zero timestamps
To:     Leo Yan <leo.yan@linaro.org>
Cc:     coresight@lists.linaro.org, mathieu.poirier@linaro.org,
        al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org,
        suzuki.poulose@arm.com, anshuman.khandual@arm.com,
        Mike Leach <mike.leach@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        John Garry <john.garry@huawei.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210507095814.17933-1-james.clark@arm.com>
 <3926c523-3fdb-66de-8b9c-b68290a5053e@arm.com>
 <20210510053904.GB4835@leoy-ThinkPad-X240s>
 <da07f930-ccd7-2b46-7b0f-0e9da3bf9482@arm.com>
 <20210512020826.GC249068@leoy-ThinkPad-X240s>
From:   James Clark <james.clark@arm.com>
Message-ID: <347cb510-0057-4687-5b29-22568d228b7a@arm.com>
Date:   Thu, 13 May 2021 16:10:47 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210512020826.GC249068@leoy-ThinkPad-X240s>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/05/2021 05:08, Leo Yan wrote:
> On Tue, May 11, 2021 at 04:53:35PM +0300, James Clark wrote:
> 
> [...]
> 
>>         /* First get the packet queue for this traceID */
>>         packet_queue = cs_etm__etmq_get_packet_queue(etmq, trace_chan_id);
>> @@ -320,7 +323,20 @@ cs_etm_decoder__do_hard_timestamp(struct cs_etm_queue *etmq,
>>          * which instructions started by subtracting the number of instructions
>>          * executed to the timestamp.
>>          */
>> -       packet_queue->timestamp = elem->timestamp - packet_queue->instr_count;
>> +       if (!elem->timestamp) {
>> +               packet_queue->timestamp = 0;
>> +               if (!warned_timestamp_zero) {
>> +                       pr_err("Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR
>> +                               ". Decoding may be improved with --itrace=Z...\n", indx);
>> +                       warned_timestamp_zero = true;
>> +               }
>> +       }
>> +       else if (packet_queue->instr_count >= elem->timestamp) {
> 
> Nitpick: I personally think should use the condition ">" rather than ">=".

Yes, good catch. I actually changed this because I realised that
if they are equal it shouldn't print an error.

> 
>> +               packet_queue->timestamp = 0;
>> +               pr_err("Timestamp calculation underflow at Idx:%" OCSD_TRC_IDX_STR "\n", indx);
>> +       }
>> +       else
>> +               packet_queue->timestamp = elem->timestamp - packet_queue->instr_count;
> 
> Nitpick for coding style, as described in
> Documentation/process/coding-style.rst, section "3) Placing Braces and
> Spaces", so here should use braces with the format:

Ok I will update and run it through checkpatch.pl before posting.

[...]