Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Sandeep Maheswaram <sanm@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Doug Anderson <dianders@chromium.org>,
        linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Manu Gautam <mgautam@codeaurora.org>
Subject: Re: [PATCH v7 1/5] usb: dwc3: host: Set PHY mode during suspend
In-Reply-To: <YJwommGqKVeMdXth@google.com>
References: <1619586716-8687-1-git-send-email-sanm@codeaurora.org>
 <1619586716-8687-2-git-send-email-sanm@codeaurora.org>
 <87tunqka2e.fsf@kernel.org> <YJwommGqKVeMdXth@google.com>
Date:   Thu, 13 May 2021 16:46:41 +0300
Message-ID: <87wns27nlq.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Matthias Kaehlcke <mka@chromium.org> writes:
>> > @@ -127,6 +142,50 @@ int dwc3_host_init(struct dwc3 *dwc)
>> >  	return ret;
>> >  }
>> >=20=20
>> > +static void dwc3_set_phy_mode(struct usb_hcd *hcd)
>> > +{
>> > +
>> > +	int i, num_ports;
>> > +	u32 reg;
>> > +	unsigned int ss_phy_mode =3D 0;
>> > +	struct dwc3 *dwc =3D dev_get_drvdata(hcd->self.controller->parent);
>> > +	struct xhci_hcd	*xhci_hcd =3D hcd_to_xhci(hcd);
>> > +
>> > +	dwc->hs_phy_mode =3D 0;
>> > +
>> > +	reg =3D readl(&xhci_hcd->cap_regs->hcs_params1);
>> > +	num_ports =3D HCS_MAX_PORTS(reg);
>>=20
>> there's a big assumption here that xhci is still alive. Why isn't this
>> quirk implemented in xhci-plat itself?
>
> That should work for determining which types of devices are connected to
> the PHYs, however IIUC the xhci-plat doesn't know about the PHY topology.
> Are you suggesting to move that info into the xhci-plat driver so that it
> can set the corresponding PHY modes?

Yes, if xHCI needs to know about PHYs in order to properly configure the
PHYs, so be it :-)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEE9DumQ60WEZ09LIErzlfNM9wDzUgFAmCdLcERHGJhbGJpQGtl
cm5lbC5vcmcACgkQzlfNM9wDzUiIlQgAmyUNbusUCCFnOyF9fdp17YNP2neOLsBY
B0OSC3VQcYJxUXIZNvUmk+FoKtvF06w4xCnU15iKod+WRUe53zmSIDmfQBtApqEi
nz8OvtF4huzSGg6IgPY40lXR96cLuOOfOsXCOzYzwsWMo04Sd5hUXvaazZYWUyeC
z5ZuRBD9KVGvULor2NRrDHO9laaTo4maccDkorTmywwczaNcxvT4lO7/qiRwTeSf
RahkCbPJ3xE7mcpfoe2goaytfAOfeAruMsc4K4JJKtZ0600pwLnaIwXnE71r6d6u
yI4DVSlTc2nbYKJ7iEpbkoYTF65tQ3hJqMy2kDy9yXeglq7tsePYvw==
=B6ua
-----END PGP SIGNATURE-----
--=-=-=--