Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH v2] watchdog: dw_wdt: Fix duplicate included
 linux/kernel.h
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        wim@linux-watchdog.org
Cc:     p.zabel@pengutronix.de, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1620904182-74107-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <8b670d5a-dc16-0709-c55a-42832ac17bfe@roeck-us.net>
Date:   Thu, 13 May 2021 06:56:59 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <1620904182-74107-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/13/21 4:09 AM, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
> 
> ./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> Changes in v2:
>    -Adjust header file order, for the follow advice:
>     https://lore.kernel.org/patchwork/patch/1428192/
> 
>   drivers/watchdog/dw_wdt.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e17..cd57884 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -13,22 +13,21 @@
>    */
>   
>   #include <linux/bitops.h>
> -#include <linux/limits.h>
> -#include <linux/kernel.h>
>   #include <linux/clk.h>
> +#include <linux/debugfs.h>
>   #include <linux/delay.h>
>   #include <linux/err.h>
> +#include <linux/interrupt.h>
>   #include <linux/io.h>
>   #include <linux/kernel.h>
> +#include <linux/limits.h>
>   #include <linux/module.h>
>   #include <linux/moduleparam.h>
> -#include <linux/interrupt.h>
>   #include <linux/of.h>
> -#include <linux/pm.h>
>   #include <linux/platform_device.h>
> +#include <linux/pm.h>
>   #include <linux/reset.h>
>   #include <linux/watchdog.h>
> -#include <linux/debugfs.h>
>   
>   #define WDOG_CONTROL_REG_OFFSET		    0x00
>   #define WDOG_CONTROL_REG_WDT_EN_MASK	    0x01
>