Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 13 May 2021 14:31:32 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com,
        robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org,
        perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org,
        rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, swboyd@chromium.org,
        judyhsiao@chromium.org
Subject: Re: [PATCH] ASoC: qcom: lpass-cpu: Fix pop noise during audio
 capture begin
Message-ID: <20210513133132.GC5813@sirena.org.uk>
References: <20210513114539.4813-1-srivasam@codeaurora.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3siQDZowHQqNOShm"
Content-Disposition: inline
In-Reply-To: <20210513114539.4813-1-srivasam@codeaurora.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--3siQDZowHQqNOShm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 13, 2021 at 05:15:39PM +0530, Srinivasa Rao Mandadapu wrote:

> +	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> +		ret = regmap_fields_write(i2sctl->spken, id,
> +						 LPAIF_I2SCTL_SPKEN_ENABLE);
> +	} else  {
> +		ret = regmap_fields_write(i2sctl->micen, id,
> +						 LPAIF_I2SCTL_MICEN_ENABLE);
> +	}

This commit doesn't remove the matching update in triger() so we'd have
two redundant updates.  I guess it's unlikely to be harmful but it looks
wrong/confusing.

--3siQDZowHQqNOShm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCdKjQACgkQJNaLcl1U
h9DuswgAhMWhYHcZug7WiZh1LrB3iTOXX6ezIaxTUNfqlza9nf4nSQw3P3tyO6ci
LZGERj2vXEi0Eukkh65G98T6YV8j4cyU+91R2pVjb1RJC+SJwSl35a4ZEco777Hq
GsOtXWYtHhpOOhpZvG+jkRSnUrkMDn1yOHPfWyApP4958rJxwqsKoHevCwuSTDrF
fMt2F5eb1qoeao46trnkbNGs1EaWYm7nbu3TFZDWa2FWxTvjJoNc00m3S+hOapMr
EsDSrpsSmcbGu7JHHGonJ4t8mdxsoIEsGy4JcPpSbbwu4mb5GZsGLGHo8jVnTF44
+uGj78EbxQRId8s4I71QW3lXnalgRQ==
=jAkE
-----END PGP SIGNATURE-----

--3siQDZowHQqNOShm--