Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp722785pxj; Thu, 13 May 2021 15:33:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS6jc1yhj3QOVytsZytkVGWto6py7Gd5yVFvix6KEepYfF3i9wQo4Gw4NkzeRaTZXDPxAL X-Received: by 2002:a05:6e02:2167:: with SMTP id s7mr597459ilv.254.1620945230294; Thu, 13 May 2021 15:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620945230; cv=none; d=google.com; s=arc-20160816; b=g2xU7BCYe6dOCXJEd+y0MsEOzDu2UcWaVtf14mPhkOTDMkblvbtucT24QNW41/yPiz Loy7ZiRNcIfqiGYHwUYhgbg6YxneYF9u8+4LCIGHyqhky/jjl/qzBSt88wk1FL/+An3b mYE1vSpljGpp/WlVQqEs58PLVGF9P3HvNZMd9aSx1We0FN7ja9q9J8qqJxVcRMNdAid9 zxSZLTjQqy/IwzDzH6KnzCQnFiDCz6pN83Pn0XBTFn4i5IWeqcvQOhDZ2+oyDW8mb5kH fJ1p0HUYWeFVx14TfTPFeuCOYvdzCX/+nBTRn6nzhTBlf7gE/Dhj3s/jggIf40YZ4per sncw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=aoIVJz3JI9Po8iMONbC92Z10QxgoVzlbka6VnP7FfAo=; b=0X9dvO/YrmyDwawgVC/scEsuPw2hWmqHByp6MC78soaZGvBDYglZaSQ4/OrnuJkrnA QQuzoyHEN8tqAc9A8jbj2+DzdFEiomdgwDSlmr02da1Rd2SiOmcn5WCWJE4hxRhPJ5BR dVEVV6oxSgRmeGQqHV4NIyfnh/AVO1lfTZUWRGkqx8QtcTmQDVPAq1F9e5a23hDXLDMN h+7VctRubUSwg+yRqPIpaKG7+Q0972pLTOBRnnoLjpC7FoiP6mraJBzHpi0kZZJ+TcOv 8hD6O/dER95aQXy9GyYa93aRfmaaZF6wC9jA+0O1DSSp6O/NUTY+0p3LEfFmsUrTOaPP eWJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si5188197iog.54.2021.05.13.15.33.22; Thu, 13 May 2021 15:33:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234669AbhEMO4k convert rfc822-to-8bit (ORCPT + 99 others); Thu, 13 May 2021 10:56:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:33402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234782AbhEMOz4 (ORCPT ); Thu, 13 May 2021 10:55:56 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65AF961433; Thu, 13 May 2021 14:54:44 +0000 (UTC) Date: Thu, 13 May 2021 15:55:52 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: Alexandru Lazar , linux-iio , LKML Subject: Re: [PATCH] iio: adc: remove unused private data assigned with spi_set_drvdata() Message-ID: <20210513155552.12f64241@jic23-huawei> In-Reply-To: References: <20210513111035.77950-1-aardelean@deviqon.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 May 2021 15:14:57 +0300 Alexandru Ardelean wrote: > On Thu, May 13, 2021 at 3:06 PM Alexandru Lazar wrote: > > > > > > > Some drivers were copied from drivers that fit the criteria described > > > above. In any case, in order to prevent more drivers from being used as > > > example (and have spi_set_drvdata() needlessly set), this change removes it > > > from the IIO ADC group. > > > > Oh yeah, I'm pretty sure that's how I ended up adding it in the max1241 > > code, too. Code monkey presents humble apologies :-). > > Well, I also added one in the AD9467 driver in the same manner. > So ¯\_(ツ)_/¯ > All look correct to me. I'll let this sit on the list for a few days before picking it up. Thanks, Jonathan > > > > All the best, > > Alex