Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp754722pxj; Thu, 13 May 2021 16:31:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFA9OnF7qIcR7Hr2zXUlLfQ67Jh4hUAL62vFlAi3ESA4v2AltEM8iCh0Rmz2Rz1FYIFvDS X-Received: by 2002:a92:cd8a:: with SMTP id r10mr38171171ilb.282.1620948688358; Thu, 13 May 2021 16:31:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620948688; cv=none; d=google.com; s=arc-20160816; b=OxLolG+VvK5FtntpblZR5s+ZCLr2tl4gmK3PoRByDG2MyQfEgG29bOC1hj3DRA6Fel ItUHKkCPlt1mHXdvQ2erjCTW8J0ZpvRYASA9EW48wcEjlV5U9Mts6234vqIAfwtn43xE sIlLoPbByu2yeQndTpGXjapAyzjdJqesR//xqu2ar6cmABu/QaXRS6BgYNfcgRt6jQ+U 9b4f3ZGdu6p4AkG2NRRoBydLCSQmBL5V7SuQT8qF/wu48VG6pECRsAhjrgFp5SXSWfNx y6Sz8l/ikfo41WdJ6XdJfSsxCS5IW7I+e7D4T+EiS7TJc4oDjuodyagHY39HH9wRpuw3 cT7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=ZJrvbudK0/CB+Jwn7uPM/X0SJ0mzoQxHfb69Fr0H5dA=; b=uWBHOq0OJYqF1Qji2Icxn+CCcDmD+UdyFebRndTnuHO9fiRY5La9CsbrRqDi1y+xWI Tlc02cpvTKWWbsM4Q0deZ+VRBOLmS3ysKZ8+6wxI2j4tSI0LiNVlt3Ar/mu9ZipYe5rr LBWl54kVp+zJIkIP0IOodCHtmQCEDbQ+DSZrw5D6nDcgea/Q8cG0q1cZBxWm6M29x8UE 32k3j7PV1VVzXNIi6ehNKycGQmDXXjEfFKloPPKV7CfS5U/n8bKisrntBXUwHIkvx0TB M3y6wW064FpqQzWsaG0OTLUJreKvYzxRvpc01AiQq6WZJuaX7WCvfUcQumYKOI69sISl TcIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q15si6092148jaj.2.2021.05.13.16.31.15; Thu, 13 May 2021 16:31:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbhEMTeq (ORCPT + 99 others); Thu, 13 May 2021 15:34:46 -0400 Received: from mga06.intel.com ([134.134.136.31]:18345 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230448AbhEMTej (ORCPT ); Thu, 13 May 2021 15:34:39 -0400 IronPort-SDR: 8ZSA5KYlQzwBAYI/NM6e94eaitqxKmIPnNPwWmIuY/6a25NL/GuieiNAyJIxipYgn0GEYcIK9u ByvYYpwbqzTQ== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="261277023" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="261277023" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 12:33:18 -0700 IronPort-SDR: +M0JYj62LXVTVTK/E7lxcG3S2SK4532ftmzu5dXEXewx0qIiI26nht/IgiagsCNy5XSBx3sXao USkz4jMZmJEw== X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="456769256" Received: from rgandiko-mobl.amr.corp.intel.com (HELO [10.212.226.208]) ([10.212.226.208]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 12:33:16 -0700 Subject: Re: [RFC v2 10/32] x86/tdx: Wire up KVM hypercalls To: "Kuppuswamy, Sathyanarayanan" , "Kirill A. Shutemov" Cc: Peter Zijlstra , Andy Lutomirski , Dan Williams , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org, Isaku Yamahata References: <04de6cd6549eee0b77fe3b0937c4b4b7f0e3ff2e.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com> <20210512130004.gxiaxj6wlzcjcem5@box.shutemov.name> <25e248b2-06f7-a450-4c9f-e90e0f0be56e@linux.intel.com> <75e63641-6dea-b339-444e-42bedbd28a1b@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <2a4e9702-5407-aa95-be9b-864775bbaabd@intel.com> Date: Thu, 13 May 2021 12:33:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/21 12:29 PM, Kuppuswamy, Sathyanarayanan wrote: >> If there isn't, then the way we do it is adding another (invisible) >> Kconfig variable to express the dependency for tdx-kvm.o: >> >> config INTEL_TDX_GUEST_KVM >>     bool >>     depends on KVM_GUEST && INTEL_TDX_GUEST > > Currently it will only be used for KVM hypercall code. Will it to be > overkill to create a new config over #ifdefs for this use case ? But, > if this is the preferred approach, I will go with this suggestion. You'll see this done lots of different (valid) ways over the kernel. (#ifdef'd #including C files is not one of them.) *My* preference is to use Kconfig in the way I described. It keeps makefiles and #ifdef's clean and obvious, relegating the logic to Kconfig.