Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Kay Sievers <kay.sievers@vrfy.org>,
        Greg Kroah-Hartman <gregkh@suse.de>
Cc:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: admin-guide: update description for
 kernel.hotplug sysctl
In-Reply-To: <20210420120638.1104016-1-linux@rasmusvillemoes.dk>
References: <20210420120638.1104016-1-linux@rasmusvillemoes.dk>
Date:   Thu, 13 May 2021 09:23:21 -0600
Message-ID: <87cztu7j4m.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:

> It's been a few releases since this defaulted to /sbin/hotplug. Update
> the text, and include pointers to the two CONFIG_UEVENT_HELPER{,_PATH}
> config knobs whose help text could provide more info, but also hint
> that the user probably doesn't need to care at all.
>
> Fixes: 7934779a69f1 ("Driver-Core: disable /sbin/hotplug by default")
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  Documentation/admin-guide/sysctl/kernel.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 1d56a6b73a4e..c24f57f2c782 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -333,7 +333,12 @@ hotplug
>  =======
>  
>  Path for the hotplug policy agent.
> -Default value is "``/sbin/hotplug``".
> +Default value is ``CONFIG_UEVENT_HELPER_PATH``, which in turn defaults
> +to the empty string.
> +
> +This file only exists when ``CONFIG_UEVENT_HELPER`` is enabled. Most
> +modern systems rely exclusively on the netlink-based uevent source and
> +don't need this.

Applied, thanks.

jon