Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 13 May 2021 20:41:54 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: make device_set_deferred_probe_reason a
 no-op when !CONFIG_DEBUG_FS
Message-ID: <YJ1y8rJNUlwtrOoN@kroah.com>
References: <20210419104256.1709253-1-linux@rasmusvillemoes.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210419104256.1709253-1-linux@rasmusvillemoes.dk>
Precedence: bulk

On Mon, Apr 19, 2021 at 12:42:56PM +0200, Rasmus Villemoes wrote:
> When debugfs is not enabled, the deferred_probe_reason string is never
> read. So there's no reason to spend time and memory on recording it.
> 
> There's still a bunch of redundant kfree(NULL) calls and NULL
> assignments, but this gives most of the benefit (avoiding two
> vsnprintf() and a kmalloc()) for the minimal amount of ifdeffery.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  drivers/base/dd.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 37a5e5f8b221..6a197336c6a4 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -216,9 +216,13 @@ void device_unblock_probing(void)
>   * device_set_deferred_probe_reason() - Set defer probe reason message for device
>   * @dev: the pointer to the struct device
>   * @vaf: the pointer to va_format structure with message
> + *
> + * The ->deferred_probe_reason string is only ever read when debugfs
> + * is enabled, so this is a no-op for !CONFIG_DEBUG_FS.
>   */
>  void device_set_deferred_probe_reason(const struct device *dev, struct va_format *vaf)
>  {
> +#ifdef CONFIG_DEBUG_FS
>  	const char *drv = dev_driver_string(dev);
>  
>  	mutex_lock(&deferred_probe_mutex);
> @@ -227,6 +231,7 @@ void device_set_deferred_probe_reason(const struct device *dev, struct va_format
>  	dev->p->deferred_probe_reason = kasprintf(GFP_KERNEL, "%s: %pV", drv, vaf);
>  
>  	mutex_unlock(&deferred_probe_mutex);
> +#endif

Can you move the #ifdef to a .h file and do this properly instead of
cutting up the function like this?

thanks,

greg k-h