Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp150902pxj; Fri, 14 May 2021 00:00:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNitli3/mvyj3SSEvdrCOQzuHjq6oP+nBVKvMwB/iUSgxGTK/1G3qv+D+9QTC9GzVJMrOl X-Received: by 2002:a05:6e02:128a:: with SMTP id y10mr37982713ilq.166.1620975658895; Fri, 14 May 2021 00:00:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620975658; cv=none; d=google.com; s=arc-20160816; b=FQXdMzftd/M+7wYJHTk6PHlBbhhp8k6+doI+bhygbozp5WwH/7optaH2V5fg1WNXFL BC/j0ygsL5FAhV/0x/P+rMfB/Hkqs9VbDHNxCM6EOmENZ5Mkl5sLS2Sj6fOgfdbLiDCM IdeF36FvVfURwPz4+KBQnmjxCvJx5F1u1H+FWepNKZiFsEOtBNOF4NP3oIJiz0vkKQ0L frcgw+SsmFC+BVhUs0cEw0qeY+urwdUsnU6957WMVvnq5YFG+iuxQhrziP2CSPw2IQy/ 7OcKBAeX8oCcB5hx+WSW6HgBKL/ETHBbZNNKWtF6yjlVTikgBDBD+MRWI5Zi6yh4uYEK bjsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=drCpqcEvjvPFW1CptBZnC8FHWDSXsJr25VKhFk4lN1E=; b=o0AGL6pWbSt5o9AgoSlSZEqcy93InMY15hHNJEEWhKs1l2CEcjD9dyiKFtqLefXYQY EGwqr39rJpyyqjW/wt9GIRmfzeDcCyqa765PLzdwR1jwg9w1AjBiPP7JGMZwZJhyMSON H2kNuGvL41mUASCu8l/mkvus2qH2apPUxcCu2qZA5CNOnK8HhtSMnYXY8HVfCO4vmobu aumdEddc2vC6fyHDMzfZogXEMRx2tFu0W+r4wNd6WmnL9toJgbJS90vcHbKz6hyeCR+i GIisgfFQrDHPOnK30jktY8Ns482j/oTEDGTUaMXTzXJ5+B2mq4qRlCiGqJa2I5RuDDVz UKQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si6349937iog.54.2021.05.14.00.00.46; Fri, 14 May 2021 00:00:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbhEMTno (ORCPT + 99 others); Thu, 13 May 2021 15:43:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:15757 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230135AbhEMTnn (ORCPT ); Thu, 13 May 2021 15:43:43 -0400 IronPort-SDR: dQpTHhT+T+lZG/wTbvIqz/VUciYWj4qhpmcMQ+loxwAbuAkR7t2dKlqm7PKqfy4hu6fFA+EdjS hgc8EWMb1VNA== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="221036039" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="221036039" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 12:42:31 -0700 IronPort-SDR: e0Du3mHH6CaeoOmjqCCFLn52k3QnHGmMVMAz17SouM6YgpcAofLKaPSs0bLQjIiI1Zh0ZF0pGU nnTy0fduuyTg== X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="456773867" Received: from rgandiko-mobl.amr.corp.intel.com (HELO [10.212.226.208]) ([10.212.226.208]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 12:42:30 -0700 Subject: Re: [RFC v2 26/32] x86/mm: Move force_dma_unencrypted() to common code To: Andi Kleen , "Kuppuswamy, Sathyanarayanan" , Sean Christopherson Cc: "Kirill A. Shutemov" , Peter Zijlstra , Andy Lutomirski , Dan Williams , Tony Luck , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , linux-kernel@vger.kernel.org References: <7c5adf75d69ea327b22b404b7c37b29712d73640.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com> <5536639a-918d-de8d-ff32-934a13902a03@intel.com> <20210512130821.7r2rtzcyjltecun7@box.shutemov.name> <943645b7-3974-bf05-073c-03ef4f889379@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Thu, 13 May 2021 12:42:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/21 12:38 PM, Andi Kleen wrote: > > On 5/13/2021 10:49 AM, Dave Hansen wrote: >> On 5/13/21 9:40 AM, Kuppuswamy, Sathyanarayanan wrote: >>> +#define PROTECTED_GUEST_BITMAP_LEN    128 >>> + >>> +/* Protected Guest vendor types */ >>> +#define GUEST_TYPE_TDX            (1) >>> +#define GUEST_TYPE_SEV            (2) >>> + >>> +/* Protected Guest features */ >>> +#define MEMORY_ENCRYPTION        (20) >> I was assuming we'd reuse the X86_FEATURE infrastructure somehow.  Is >> there a good reason not to? > > This for generic code. Would be a gigantic lift and lots of refactoring > to move that out. Ahh, forgot about that. The whole "x86/mm" subject threw me off. >> That gives us all the compile-time optimization (via >> en/disabled-features.h) and static branches for "free". > > There's no user so far which is anywhere near performance critical, so > that would be total overkil The *REALLY* nice thing is that it keeps you from having to create stub functions or #ifdefs and yet the compiler can still optimize the code to nothing. Anyway, thanks for the clarification about it being in non-arch code.