Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: mmotm 2021-05-12-21-46 uploaded (arch/x86/mm/pgtable.c)
To:     Andrew Morton <akpm@linux-foundation.org>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
Cc:     broonie@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-next@vger.kernel.org, mhocko@suse.cz,
        mm-commits@vger.kernel.org, sfr@canb.auug.org.au
References: <20210513044710.MCXhM_NwC%akpm@linux-foundation.org>
 <151ddd7f-1d3e-a6f7-daab-e32f785426e1@infradead.org>
 <54055e72-34b8-d43d-2ad3-87e8c8fa547b@csgroup.eu>
 <20210513134754.ab3f1a864b0156ef99248401@linux-foundation.org>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <a3ac0b42-f779-ffaf-c6d7-0d4b40dc25f2@infradead.org>
Date:   Thu, 13 May 2021 14:08:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210513134754.ab3f1a864b0156ef99248401@linux-foundation.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/13/21 1:47 PM, Andrew Morton wrote:
> On Thu, 13 May 2021 19:09:23 +0200 Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> 
>>
>>
>>> on i386:
>>>
>>> ../arch/x86/mm/pgtable.c:703:5: error: redefinition of ‘pud_set_huge’
>>>   int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot)
>>>       ^~~~~~~~~~~~
>>> In file included from ../include/linux/mm.h:33:0,
>>>                   from ../arch/x86/mm/pgtable.c:2:
>>> ../include/linux/pgtable.h:1387:19: note: previous definition of ‘pud_set_huge’ was here
>>>   static inline int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot)
>>>                     ^~~~~~~~~~~~
>>> ../arch/x86/mm/pgtable.c:758:5: error: redefinition of ‘pud_clear_huge’
>>>   int pud_clear_huge(pud_t *pud)
>>>       ^~~~~~~~~~~~~~
>>> In file included from ../include/linux/mm.h:33:0,
>>>                   from ../arch/x86/mm/pgtable.c:2:
>>> ../include/linux/pgtable.h:1391:19: note: previous definition of ‘pud_clear_huge’ was here
>>>   static inline int pud_clear_huge(pud_t *pud)
>>>                     ^~~~~~~~~~~~~~
>>
>> Hum ...
>>
>> Comes from my patch 
>> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/5ac5976419350e8e048d463a64cae449eb3ba4b0.1620795204.git.christophe.leroy@csgroup.eu/
>>
>> But, that happens only if x86 defines __PAGETABLE_PUD_FOLDED. And if PUD is folded, then I can't 
>> understand my it has pud_set_huge() and pud_clear_huge() functions.
> 
> Probably because someone messed something up ;)
> 
> Let's try this.
> 
> --- a/arch/x86/mm/pgtable.c~mm-pgtable-add-stubs-for-pmd-pub_set-clear_huge-fix
> +++ a/arch/x86/mm/pgtable.c

That also works_for_me.

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

thanks.
-- 
~Randy