Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp264915pxj; Fri, 14 May 2021 02:56:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxINoP4QM/z3+ZigpEg4XRcSUBupoWVqNj0SLoiN3JPjVu/b850yDwCA5cFz31PSY/DzvQh X-Received: by 2002:a92:1304:: with SMTP id 4mr39333140ilt.126.1620986165274; Fri, 14 May 2021 02:56:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620986165; cv=none; d=google.com; s=arc-20160816; b=atPWOl8fdY1hwlGFL8hegzyt/lMuh7RikU5VLxumxoeo8FldJ9Cqzjuk8qNwYI6/bc W7+gca8Wf184yz7uArPGz98DVNcf1qe/pJIss2oJPYUfGZaoH05cbzuSAHo5clfYy0qF FtmLkXI840fgUutkzwl1i7ufUwufNrOYt7/DUzBQjqe+iioyHzvTx6j+SBL0C59M8aws G1YyTT0rHSnuR62aElXPAIpfKLJFE65dCnWOtky+VoCRdD+YLMcsLWbmKDfMZviSm5t0 AJdmYC0Qqs0zINnuUzNT+D0Dweqe7SOzxYaAads0ANkLjx/Xy/PqhZ77QgO0hKCoAqHH JOYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=t60ws+/S1xbaHgL2J6bzHmgruOs8FY0ShcS+kCfKXj8=; b=zY0+3LPR2fycI+EbFuDQqhdLJlluEdnIdjNgSg7zmIv8H7ReA9T9d6RTeKunF4RQU8 gNvNLDV0joUuDhxWfshBIa/JQa+C1w6I06xJ5vWg0MOhOmge8w+hl4KpxnAmu4/vyFRx v1oUv0NlnR/Q4RacW1Y3n/9Y0XCnr+xUrDP4pshQlb5fVr/kyglL4zgJUIBYF/rP+Oum uCK+W2liIPwJX+vyIbJfcLtUzfduQgtKpQMbe1F56/FDuDQ18Pgv5Wq4+tDatumpA18c wK7nez5zDqKCe8B+ecpb0cxgePpR1X8cvkQzMxP6f2zGwymDoyOP4UF1+jOjZYpGPhNl RYdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si5240957ils.162.2021.05.14.02.55.53; Fri, 14 May 2021 02:56:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232795AbhENHE2 (ORCPT + 99 others); Fri, 14 May 2021 03:04:28 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2658 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231433AbhENHE1 (ORCPT ); Fri, 14 May 2021 03:04:27 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FhKCV5NX9zQnJk; Fri, 14 May 2021 14:59:50 +0800 (CST) Received: from DESKTOP-EFRLNPK.china.huawei.com (10.174.176.189) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Fri, 14 May 2021 15:03:07 +0800 From: Qiheng Lin To: , Phong LE , Neil Armstrong , Andrzej Hajda , Robert Foss , David Airlie , Daniel Vetter CC: , , , Hulk Robot Subject: [PATCH -next] drm: bridge: fix wrong pointer passed to PTR_ERR() Date: Fri, 14 May 2021 15:03:06 +0800 Message-ID: <20210514070306.606-1-linqiheng@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.189] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned. Reported-by: Hulk Robot Signed-off-by: Qiheng Lin --- drivers/gpu/drm/bridge/ite-it66121.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index d8a60691fd32..6980c9801d0d 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -943,7 +943,7 @@ static int it66121_probe(struct i2c_client *client, ctx->regmap = devm_regmap_init_i2c(client, &it66121_regmap_config); if (IS_ERR(ctx->regmap)) { ite66121_power_off(ctx); - return PTR_ERR(ctx); + return PTR_ERR(ctx->regmap); } regmap_read(ctx->regmap, IT66121_VENDOR_ID0_REG, &vendor_ids[0]);