Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 May 2021 09:47:09 +0200
Message-ID: <s5hv97l92pu.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     <perex@perex.cz>, <tiwai@suse.com>, <gregkh@linuxfoundation.org>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ALSA: gus: Replace unsafe strcpy() with strscpy()
In-Reply-To: <20210514070507.16600-1-yuehaibing@huawei.com>
References: <20210514070507.16600-1-yuehaibing@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 14 May 2021 09:05:07 +0200,
YueHaibing wrote:
> 
> Fix smatch warning:
> sound/isa/gus/gus_main.c:396 snd_gus_check_version() error:
>  strcpy() 'card->longname' too large for 'card->shortname' (80 vs 32)
> 
> Even if this is not a real bug since the longest length of card->longname
> now is 31, replace strcpy() with strscpy() in order to avoid possible
> future mistake.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied, thanks.


Takashi