Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp272616pxj; Fri, 14 May 2021 03:08:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNAqI+krBwqfGilLQHzLqs2I4M3YPmTyJboaIkfN13LseeA67b+hDsgXb39fTx8eiO2sGQ X-Received: by 2002:a02:7110:: with SMTP id n16mr42015062jac.69.1620986900559; Fri, 14 May 2021 03:08:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620986900; cv=none; d=google.com; s=arc-20160816; b=KddsckF/6C3+G2901QW9WXelqwE+RrDQdysAkcFlcm/YPqtUWxDar68Z7sIN90MGyj UXiF96IARsfb2+RtF8dF+CfTJXNUK1sAyXihjiOFRuSuHBtJasJEDOtew80/So7nDwQg RncpUDmT1kjUY9MLU/LXpMbRt4O+Fdra/NqJHY4vbez9rHnPH04ArZUD3gzJ+xgT1oQ3 wngelL0uNzPuEPwGSlqaPZeedtu/vPYhu9jweq75Htf11fzk/7odh8pXmN/5i+2+cqYd 4qYWcyX0hxRea7ssXRN+SUQZGJ401e8yAez98mi1rPInPabsxMz+FqGQGj3B9hKYQt5o W5iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=w+WgH2TqQ3nSvlsHuEFFZhymKJGlTDhXNwhUbtG0WD8=; b=hCN0cL4LBreQSbDEEySeJfaMJT6pqild4FUKj+zzepB5PYYZYHkflIpB0cc8lBSIYt Uk0b9BZcrh6GemaN3gw9FO/D0E/H6HeW84Mf3K5z3TRD4/iJgTVDgVQllm0Q5XOiGRD2 vdnFxA1uPxCGYuyiH6oVg4HlOWbrVnwYa8mHic2hFN5Sw3jHxJlwNhb6qLvUZiQ5lQ2n ijeeJy96gimTnKqiXBKz8kV4KvJjB28R207Fl4ndZgo24q9fdTqNU1ZR6FkDg5/7t1VA hO0hgyINHopEANq4pnNwvVYivoKvNK759vXGuVyxNupGXDDUy4mCd1Iqcxduuv9bnXA4 JU6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v20si6626012ilo.64.2021.05.14.03.08.07; Fri, 14 May 2021 03:08:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbhENHvw convert rfc822-to-8bit (ORCPT + 99 others); Fri, 14 May 2021 03:51:52 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:42162 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233222AbhENHvv (ORCPT ); Fri, 14 May 2021 03:51:51 -0400 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 14E7oLlaD025885, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36502.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 14E7oLlaD025885 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 14 May 2021 15:50:21 +0800 Received: from RTEXMBS01.realtek.com.tw (172.21.6.94) by RTEXH36502.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 14 May 2021 15:50:20 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS01.realtek.com.tw (172.21.6.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 14 May 2021 15:50:19 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::1d8:ba7d:61ca:bd74]) by RTEXMBS04.realtek.com.tw ([fe80::1d8:ba7d:61ca:bd74%5]) with mapi id 15.01.2106.013; Fri, 14 May 2021 15:50:19 +0800 From: Hayes Wang To: Greg KH CC: Alan Stern , syzbot , "davem@davemloft.net" , "kuba@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "syzkaller-bugs@googlegroups.com" , nic_swsd Subject: RE: [syzbot] WARNING in rtl8152_probe Thread-Topic: [syzbot] WARNING in rtl8152_probe Thread-Index: AQHXRxMNo04dZcfiN0eNJrSRsQsh6qrguwNggAA4ewCAAVQHMP//vp6AgACQRgA= Date: Fri, 14 May 2021 07:50:19 +0000 Message-ID: References: <0000000000009df1b605c21ecca8@google.com> <7de0296584334229917504da50a0ac38@realtek.com> <20210513142552.GA967812@rowland.harvard.edu> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.203] x-kse-serverinfo: RTEXMBS01.realtek.com.tw, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2021/5/14_=3F=3F_06:00:00?= x-kse-attachment-filter-triggered-rules: Clean x-kse-attachment-filter-triggered-filters: Clean x-kse-bulkmessagesfiltering-scan-result: protection disabled Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Outbound-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 05/14/2021 07:29:27 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 163650 [May 14 2021] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: hayeswang@realtek.com X-KSE-AntiSpam-Info: LuaCore: 445 445 d5f7ae5578b0f01c45f955a2a751ac25953290c9 X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: realtek.com:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 05/14/2021 07:31:00 X-KSE-ServerInfo: RTEXH36502.realtek.com.tw, 9 X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled X-KSE-AntiSpam-Outbound-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 05/14/2021 07:33:30 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 163650 [May 14 2021] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: hayeswang@realtek.com X-KSE-AntiSpam-Info: LuaCore: 445 445 d5f7ae5578b0f01c45f955a2a751ac25953290c9 X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: realtek.com:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 05/14/2021 07:36:00 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH > Sent: Friday, May 14, 2021 2:49 PM [...] > Because people can create "bad" devices and plug them into a system > which causes the driver to load and then potentially crash the system or > do other bad things. > > USB drivers now need to be able to handle "malicious" devices, it's been > that way for many years now. My question is that even I check whole the USB descriptor, the malicious devices could duplicate it easily to pass my checks. That is, I could add a lot of checks, but it still doesn't prevent malicious devices. Is this meaningful? Best Regards, Hayes