Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 May 2021 10:10:42 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 245/530] tty: actually undefine superseded ASYNC
 flags
Message-ID: <YJ4wgpBvKOlPl4lg@hovoldconsulting.com>
References: <20210512144819.664462530@linuxfoundation.org>
 <20210512144827.885941093@linuxfoundation.org>
 <YJvxjC5qyyRmLSyB@hovoldconsulting.com>
 <YJ4s1Ut2HYyjL0H7@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YJ4s1Ut2HYyjL0H7@kroah.com>
Precedence: bulk

On Fri, May 14, 2021 at 09:55:01AM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 12, 2021 at 05:17:32PM +0200, Johan Hovold wrote:
> > On Wed, May 12, 2021 at 04:45:55PM +0200, Greg Kroah-Hartman wrote:
> > > From: Johan Hovold <johan@kernel.org>
> > > 
> > > [ Upstream commit d09845e98a05850a8094ea8fd6dd09a8e6824fff ]
> > > 
> > > Some kernel-internal ASYNC flags have been superseded by tty-port flags
> > > and should no longer be used by kernel drivers.
> > > 
> > > Fix the misspelled "__KERNEL__" compile guards which failed their sole
> > > purpose to break out-of-tree drivers that have not yet been updated.
> > > 
> > > Fixes: 5c0517fefc92 ("tty: core: Undefine ASYNC_* flags superceded by TTY_PORT* flags")
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > Link: https://lore.kernel.org/r/20210407095208.31838-2-johan@kernel.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > 
> > I don't think this should be backported to any stable tree and the
> > stable tag was left out on purpose.
> 
> It's about time that userspace gets this right, so this should be fine
> as it's something that any out-of-tree code is going to have to get
> correct eventually.

Eventually, yes. Just doesn't seem right to break stuff on purpose in a
minor stable update.

That said, I really don't care one bit about out-of-tree drivers so go
ahead if you want to.

Johan