Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp284292pxj; Fri, 14 May 2021 03:27:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFAuZzkDE6O5Ofe92AnQ8pAzfBvSznQXFgb77wRILRmm2/3PF5Wyq++OlcZvmXUne/Aco7 X-Received: by 2002:a92:d24a:: with SMTP id v10mr6696040ilg.247.1620988045508; Fri, 14 May 2021 03:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620988045; cv=none; d=google.com; s=arc-20160816; b=N9LiuhOrh9pulWueZ9/s2qa8TOiY8K0eHB2ywX87N2f/gNV+dCPhh4nVVfUJ18Eot+ UfLTPrWtiEZNf94Yq3QUAeVojNktwFwx6vZRv8+/CTgp41arZhI3T1ZO9m+ZuArH7psU ddo1WCDdYW/5urqSNlE6Fs2g0Vz1oFCIFH+gay9Ep1/rnuTD1+m+Pi1RaOnv7xNnBsf+ OG552SoQSYv+BJD/etgUdXFW3DzgT7OW7Ki5tm6K2DwhVnNFmsglyJD/f8eGr8LxkkmU xRnd/FOb963I+nU5+cnT3miieP1S2Pp/AYswUfDQO5Toe6ZK35Bkt6/Pr+8ejAve4oYM wD7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=6uA/UUkc0ViJ/2YRaUldx05MrsQE2UfYmoMseM3ZwZM=; b=j7GUIpzFrM72s4iIJAdYEML/bd+9l4Fn/ly+7kaZHuzJMScEbW8Zs1aWr5radFREqL O8pmfhRez32RaBZb5tWGOmjNZ18OU50k4P3AsVeMho1r7yVhub5MSMFCVszRVkV2IfuK euCiIHAF1Ffyjv0HIJguFOGuYvzw26CFnkf+XwJl2wQ7P/ieiIF9GBezlqcvn//sDh/9 cAoTR66TIeYMHeElnKwcnWiV5srmQzRoDUooWcroqateBJFLaqDwKIjhXcbjmNPEFKHz GWaXApVcy5EUm/7Q67jT2J+a7mBpaZFKwk1geYt1vzJlNbpFtgXAW1RHfubuLu7kDuzt cOsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZK4hqy9l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q145si7735545iod.36.2021.05.14.03.27.13; Fri, 14 May 2021 03:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZK4hqy9l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233644AbhENIkO (ORCPT + 99 others); Fri, 14 May 2021 04:40:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhENIkN (ORCPT ); Fri, 14 May 2021 04:40:13 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76361C061574 for ; Fri, 14 May 2021 01:39:01 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id n25so33858165edr.5 for ; Fri, 14 May 2021 01:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=6uA/UUkc0ViJ/2YRaUldx05MrsQE2UfYmoMseM3ZwZM=; b=ZK4hqy9lY4WOC7ITURSwXwumBMAF0mS4b8rWte1LIqOdoROqHS3jnN0ClnzNwL8+Vk 9LnXzZsgtmb5kcEwYUFimU5rDxwfqH18XCl2QFgdqy05uw824vl9eaTEO2OEqxNWGAnl I5lTIpcMYPgsEWa3SeUA8rmpGQb244riN6vNKtoP9C1elotQEMxJQ7CMUVPutYwsow4+ yGu3XxCIu6jYdCncsC5STa+WttgvhhBj0Odvs8PiqSAvHzwgnWk/Cw2woWne4S2O2zXo 8TQaQ1VMkzQexTJ4LBSug+QJT8vJnriE7pmXPTEzRwrUauX/oZYddTPObjYqCVrH8/K2 /rlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=6uA/UUkc0ViJ/2YRaUldx05MrsQE2UfYmoMseM3ZwZM=; b=mwKmMJqMcEwlCrssz6gEEjftK2VYe8nMsatlPD2+2/9m5/T63fKjPALycD0t+nFUfw 9xoebfnFj6EYwLAwic7PzrVtfqZKKBqAR6n/o2iqnUfTIp0S/W/hdC604OFhg8DzpNKA ygKv5FyAJdWrr+SEkCDoPjXddDVZtWkPhGK0oXIpgJ5gnJkfB92WQSpesWP9nFo07JlS tmn2EBYpoHXE1+g0dPqx3EgVhXtrNckZqC/w15BHJfbwq23oY+C/bfsFv1zPIFm/MKUf qqgd2VCTS2+WUYjDnfMiClW+uPg1gPKOcxyGsb7mHecj4cpML2/oUUEC5s6KfhrecEon KWBA== X-Gm-Message-State: AOAM530fwtibMKn/Uj/ssF/1kYMYqgQC9lefCzEwk9MvQvyvxuxAv9Qc h6q8XMtgL9q94MdetNHqiCJcgVhfz18V8A== X-Received: by 2002:a05:6402:652:: with SMTP id u18mr54957386edx.388.1620981540181; Fri, 14 May 2021 01:39:00 -0700 (PDT) Received: from agape.jhs ([5.171.81.81]) by smtp.gmail.com with ESMTPSA id k5sm4552527edk.46.2021.05.14.01.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 01:38:59 -0700 (PDT) Date: Fri, 14 May 2021 10:38:57 +0200 From: Fabio Aiuto To: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: staging: rtl8723bs: questions on TODO list Message-ID: <20210514083856.GA13800@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello all, I'd like to have some clarifications about rtl8723bs driver. In order to make this driver ready for moving out of staging I would like to know: - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. is it possible to remove all 5g code, even the one related to power regulation when on band 5g? As far as I know about this card is that it doesn't support 5g, so may I just delete all 5g code or there are some constraints I'd take care of? - find and remove any code for other chips that is left over Ok this seems clear, are there some suggestion to do it safely? - convert any remaining unusual variable types Ok (but feel free to suggest anything) - find codes that can use %pM and %Nph formatting Ok (but feel free to suggest anything) - checkpatch.pl fixes - most of the remaining ones are lines too long. Many of them will require refactoring Ok - merge Realtek's bugfixes and new features into the driver Please, can you explain what one could do that? - switch to use LIB80211 - switch to use MAC80211 I think I need a few details for these last points as well. Do you think that one will need real hardware to complete these tasks? I don't have rtl8723bs card at the moment, so I think I will focus on those TODO activities which don't need it. thank you in advance, fabio