Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp333112pxj; Fri, 14 May 2021 04:45:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTCykZ9hlj26exptuz679CYUrhY0ou1AyiqvTHxhTtbIUhJ+cElWOJ6oskOfWfBBzasnpe X-Received: by 2002:a17:906:36d1:: with SMTP id b17mr50185015ejc.235.1620992713643; Fri, 14 May 2021 04:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620992713; cv=none; d=google.com; s=arc-20160816; b=V6r/gH4eZqChYs+9DCoEZM9c94IFeVQ+mUeQirnh0tde2JE3krNF8HQSIwG73A4X1i rVFqu7B7R3zvmWBk+7QyqkfEQBqeSJ9WdCnrKxF0OOKhxDC4i4JLTiviyLfCNXDP6BJN 90iCAIhbTdFNZRVrsZ1MNQg5iNp4uyqcbO7VZ0S57go6DVuvYjq4GVJ5v3PfhPnUpsBc SR/X+RWaGZSk7/wkNEFbqJVP+lcyW9Q9eJiElvNmjIR5dYTDfblMlbZksTu7bKRAJqyN As0LYNSPNvzzNEqq5xml2lox8PYmM3tLqA6l3F2jilDYT5tSxz++FHOXDtDWwyiT9aq6 2Jew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=d8T3/Qrb0Majaz/ilL5pSfmfhEJBBMEbrzxBym7PoP0=; b=PJfQWh4r1IhLdY4a4J17hiV0ivemybyQ/MUMIYJoZEPVQ7eFKJYVZtRsmTtd+izn2i 6o8sYPOnuoW1hRxe18PJgzLXGuQyN0a4kwtuBXBzWJCtJJhAFWOtoRoPl/N94/vjO2lg RRSRI+HvwND08o1SiVsIv8ZiTH6mG4LVXhDVZ4ePFOdI8sXYx1xGmt2gi7/n8lup9mcQ ZN2dvREhdtVpCju7KXxuLYDRrIUXrxfnlmVOCTUNVUmXj3cgKfeJugzw2fQfdPNpY4hH SrX+C5VjeUB5wIAPyb44eZDg5zzYUHjS7LLGTlkZpGZGH9SyihIcP0mrgShkjO7+lcHL kBRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=z+k3QNWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si5457313edj.468.2021.05.14.04.44.50; Fri, 14 May 2021 04:45:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=z+k3QNWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232134AbhENLog (ORCPT + 99 others); Fri, 14 May 2021 07:44:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:59446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231433AbhENLof (ORCPT ); Fri, 14 May 2021 07:44:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 19E6B61457; Fri, 14 May 2021 11:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620992604; bh=gIAAi7Doig6rhs/h2Olonq+YDcMN+whb09ZfjqXO6Cw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z+k3QNWQExai9fOKQaRZxECkKCK6tMUELvHKYCRFw4aESU7Tixrndvzt0Ah5fZfaE tN/WVMn76uhSE/xQY3gu1oGFO/LmVHa4yk8n5vYPlp1cMvbhOwYf8OLIU4M2w19skk +zTtT5VAqmR/TiQPStTzrdZ/nX4flTvQv1yXRJgQ= Date: Fri, 14 May 2021 13:43:21 +0200 From: Greg KH To: Christophe JAILLET Cc: fbarrat@linux.ibm.com, ajd@linux.ibm.com, arnd@arndb.de, mpe@ellerman.id.au, imunsie@au1.ibm.com, mikey@neuling.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] cxl: Fix an error message Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 05, 2021 at 09:38:49PM +0200, Christophe JAILLET wrote: > 'rc' is known to be 0 here. > Initialize 'rc' with the expected error code before using it. > > While at it, avoid the affectation of 'rc' in a 'if' to make things more > obvious and linux style. > > Fixes: f204e0b8ce ("cxl: Driver code for powernv PCIe based cards for userspace access") You need a full 12 digits for the SHA1, otherwise our scripts complain about it :( I'll fix it up here, but please fix your tools. thanks, greg k-h