Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp433643pxj; Fri, 14 May 2021 07:02:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq4Wg5Jx5RKe1RPZm7T/clwHmbBQ6JKJtF/dX183thglYYEzPMtfiFrCnQvI4pK6HpEou+ X-Received: by 2002:a50:fb8c:: with SMTP id e12mr6243592edq.93.1621000970413; Fri, 14 May 2021 07:02:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621000970; cv=none; d=google.com; s=arc-20160816; b=HTQhztT6uQayDMBAh2aM4fE+R82V92MlL69806QOmZwoxdgiuO1WU9rctD8T6kE/2j omBVFy1VCuTXgc+/rKRxhatDDWOor+AcP4A7ElwxY7r6/gSwo9P665ySmQIroxb299dN nAhb8HH2K+gGbfExZWwpzmj2DcNVqHBiZvN/3m2QWbj3AF/l7cwk3APTQtWg1YgjKCK1 Oo2lGTgPNB+j9BfzihMRCjNNZmYcAU/j+JfzIpSaP7Jwc7r7nlr9oNdjFFfIbntrrrHP dkeSoQZOtMjLmkXQTbFlU3r7b9B4gdWl3saaRf5ScuXVLbYYx5qYvj2AKURUdijrXOtW 8qNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=5ZGfDBUrNWhCSaHrQuJL3OoEl76IDlh3XWOdo3PqI7k=; b=zp6IciAVmE3poOF/r7Y1N0i23HUkolyBunh3hXr4xQaliwEQKhJBv51j2IURR3Z/ke gLoRgANMa38yCisEa4U1hznvbdo4lA8K0F0UePrvtD/kk3vN7jBOHP72n1NBS6lE8NC5 vdfRFIT1Pr5UL+8qWXTykF0p69VYSsxVA4FyMR7jaFztN5N9iMVaXtQBLLKYQbDNPGIr DDf6DNidO4uyBBTpW4VRlJ7NWUP0siBuU2FS0oK6m8MQj9ODUK/yqDnbqae/KjUKtoqC OkOp2UKSBFbBrvEJ60ZfKVUJwi5ad7M7A1FGg7D5Kb4R0J+eaJI5MEjCmFXy+KQ9Gkcg yfnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si6494442edy.288.2021.05.14.07.02.00; Fri, 14 May 2021 07:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232079AbhENGJo (ORCPT + 99 others); Fri, 14 May 2021 02:09:44 -0400 Received: from mga03.intel.com ([134.134.136.65]:26236 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbhENGJn (ORCPT ); Fri, 14 May 2021 02:09:43 -0400 IronPort-SDR: 3Xyli9/7yfOlocWwXKI+TkK4REjlJmT25GsS75wMtNI62bY96ULEh5VLAvEEpCnOe0uBGfermr wjOXuYnfuI6A== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="200173452" X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="200173452" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 23:08:32 -0700 IronPort-SDR: OVpRxzo16RRPvJ8fQmnwz3lhFfI4tXFxq7IabNxvPKMhjhL+sHcy58mMQEQRrWEfnCm17VgK6F 88xToPKlXcyg== X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="624250058" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 23:08:29 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 14 May 2021 09:06:18 +0300 Date: Fri, 14 May 2021 09:06:18 +0300 From: Mika Westerberg To: David Gow Cc: Brendan Higgins , Daniel Latypov , Shuah Khan , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 07/10] thunderbolt: test: Remove sone casts which are no longer required Message-ID: <20210514060618.GA3511397@lahna.fi.intel.com> References: <20210513193204.816681-1-davidgow@google.com> <20210513193204.816681-7-davidgow@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210513193204.816681-7-davidgow@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, May 13, 2021 at 12:32:01PM -0700, David Gow wrote: > With some of the stricter type checking in KUnit's EXPECT macros > removed, several casts in the thunderbolt KUnit tests are no longer > required. > > Remove the unnecessary casts, making the conditions clearer. > > Signed-off-by: David Gow Looks good. Does this go through KUnit tree or you want me to take it? In case of the former feel free to add: Acked-by: Mika Westerberg