Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp441798pxj; Fri, 14 May 2021 07:12:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwMHQYXW4zCXuDhC/cIxlWnxrPmvXxh3gDgaAEA/9CMH4y+XYsX/3GhDJD5yv4mlkAqirT X-Received: by 2002:a05:6402:51c9:: with SMTP id r9mr52395979edd.94.1621001533914; Fri, 14 May 2021 07:12:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621001533; cv=none; d=google.com; s=arc-20160816; b=DT+Zr8FkZrN5E9xpVM//1lsCDNDXQQCs6rcD9DU2Zzb7WaHl/r/FtlhjdjlM5S5Fft VB+g5Z6HS/8/nZK5llevKULszMF+CJmA7o5Vgi/UaFfzIi8FG+RiSGCqFupYJkcXbixc SYfJzj/Zqi3K3pD2C3ACEloSM820nAW+BmvfR2FhpEs2f1HwtgfNG+vVdaBuCGGZ6eMK Y8UkDsS0gQD/ekCnhs/zT8KcvKcxQRLnuOONiT8C/rna9F/BKZ0VoKGWP7zvX6T6DRYV 7G6PE7v7sTt15ZvcsdQ5nb5jDKHnE7wx0AQrDzuM/l2GWfjkLenUva0SLCEfIR0hbz9W 8O8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=15ezUcoX2Tp5onmLNEbYjA7IRAW1s32VZAsjPbUMDow=; b=BXbnH+IaofVD2+Iiu2voFF8wKfCMhgVGmUDkn++8HKoukBaZzQZ/y9ost1kdDAzujc F9fdxrI9FuNRK10JOQVQbGEKv+OYKTDws4tj//ksP8sbFPo0o4K3xbmACQCt6w5X7y6T DlNDuJ2uk7J79jIJkxuayJ72U9q/NT+JNwVw2W5IiKlLRdJ9gGm1qwSrySO7XbIRV+S7 KUXPnGe2ZQwXsUET5zLVfBQypXglGmq8f8BZuiEFGpmZo4vybI6BC4L0P6228jRKCo63 iz27nvXragm8gSoLZpdX4CnRh1LZLSnpDG5VPEToRgHdrPq3UIpM+T1S003EHTFP42CN 8nvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZygTqMk0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si573429edc.126.2021.05.14.07.11.49; Fri, 14 May 2021 07:12:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZygTqMk0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232778AbhENH0M (ORCPT + 99 others); Fri, 14 May 2021 03:26:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:55586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230326AbhENH0L (ORCPT ); Fri, 14 May 2021 03:26:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A436561446; Fri, 14 May 2021 07:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620977100; bh=15ezUcoX2Tp5onmLNEbYjA7IRAW1s32VZAsjPbUMDow=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZygTqMk0DJgrTsghfeYNhwDq/A2Re2zuZq73koYZX9dSAxSTJGNGMewoHynPWP9OK tyjXLV8feLl1cQW7K51qvI9gaDAbyNLf9fsuTC8GWNcUmQAcQNrYeRo3LvWOKusKfC u+dFSPgr6AQVUmiLbYGM5XiFxmqTNDSdHardsgZLnDDWVwRHUbfFSYWUhozMLl3NWu xKWI0tvuk0bqyn1cax0UPNkX8M479xy960BvU8QwGFa+tjs5+SITjval+q4fvNUGs2 g5WWMQ1p6q+srbokCw8B3UuBQAfG2MFcaSnOX3XyFlgQHZY2zzs/48wy52snIqq3QT g24j/t25VVGDQ== From: Felipe Balbi To: "Gustavo A. R. Silva" , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] usb: gadget: s3c-hsudc: Use struct_size() in devm_kzalloc() In-Reply-To: <20210513193353.GA196565@embeddedor> References: <20210513193353.GA196565@embeddedor> Date: Fri, 14 May 2021 10:24:50 +0300 Message-ID: <87k0o17p6l.fsf@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable "Gustavo A. R. Silva" writes: > Make use of the struct_size() helper instead of an open-coded version, > in order to avoid any potential type mistakes or integer overflows > that, in the worse scenario, could lead to heap overflows. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFFBAEBCAAvFiEE9DumQ60WEZ09LIErzlfNM9wDzUgFAmCeJcIRHGJhbGJpQGtl cm5lbC5vcmcACgkQzlfNM9wDzUh9UQgAoHsTFS64PtkTiiLe9txwadAGZu1jUqWd rifBnWCjW0qkcPu6k74kykvO743iZ8S1NBFifgaARaSmiPvH3v6hIYbiN+co+QWR dvkErw3FeTn5FqhAJdamv4nXcRecdmiutseGRUBExLA+vjbDKrCAp+3MNzf9emws cTyBJaRgp0GCshhHyGKzvxRLRDt3USNBvN67vIxJMNgC0C2gg1D8Kp6qok5PzJCq ppiCSPMw6ytSbKUGh5XBATPcgxE64jRoFFNObtPxByKlmvqTKC6rYQ0I9y48un+c /Lo/5hc2yiepHWuwx6LE+LSSCkoFDQnhZt28yDELxP7Tl0bXqDnK3g== =3cIq -----END PGP SIGNATURE----- --=-=-=--