Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Fri, 14 May 2021 09:07:26 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/acpi: Switch to pr_xxx log functions
Message-ID: <YJ4hrrUkKRkKsUtf@gmail.com>
References: <8436da08-4812-d383-8f2a-1c07181ebfb8@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8436da08-4812-d383-8f2a-1c07181ebfb8@gmail.com>
Precedence: bulk


* Heiner Kallweit <hkallweit1@gmail.com> wrote:

> Switching to pr_debug et al has two benefits:
> - We don't have to add PREFIX to each log statement
> - Debug output is suppressed except DEBUG is defined or dynamic
>   debugging is enabled for the respective code piece.
> 
> In addition ensure that longer messages aren't split to multiple lines
> in source code, checkpatch complains otherwise.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  arch/x86/kernel/acpi/boot.c | 118 ++++++++++++++----------------------
>  1 file changed, 47 insertions(+), 71 deletions(-)

Reviewed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo