Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp459131pxj; Fri, 14 May 2021 07:36:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQNVNP9L/Jc6D/LJ2PtD98r6kwoLoyoNeK/8El5az9b9MAe52ojHnNPlFCYWLoZMzz0kly X-Received: by 2002:a50:fe8e:: with SMTP id d14mr9265678edt.97.1621002992641; Fri, 14 May 2021 07:36:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621002992; cv=none; d=google.com; s=arc-20160816; b=hL8wRcxJ8+Aft0gbsaIqfWScLDIivtT4L+06kXgnyZ3kVkE5A7+Qei66UIQutycnxO UmNt8+uR4jsEcxPLHTwTsmXWcHwYAH9jC7rwLSlmcOixSweEn6Og0qq4xYuma6h3qU+q 41MADDs0WNrSi6I7KtOMM/EdDp2OZIMY3/B3qQEjslQpsaijKuONfTFliNQ4Q2ChFzhG IG8KPA246gNdfwzrtGg+V46+nNu9iVnAwI/eWxcs7OEzmGyYQf/tkN/t/1IX1LX3ZkWh ojzmuWFovARNB2rsd2jjqBiPAIipWdLIV+1ppR5zhZmTEHh3faaVD27w+wGF/GQwo4Dn 2jhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=E9tnZ9evfnbV2gxFSdDXTY64rXupCRZyW/vv9n4TlN8=; b=CtQSbm6i9UW9mKsywGhCuX3RHz36gURdMc3ip/l0qIAHYTMLZyiB0CtnzZeDhVIs8P PcQtazzhlSsYMTA3OICe9zBs83HSf0pWyUozy/9NvHuqyUuTiX3X3mxIrShZQHrU7NEt UBuFWnrtUt96K8+R9xeJlwoRwuIfs1BY++Caui3grZW5eavaug8H6+eswrl8bS5jhjuf oQDXiM/Z9N8TBcPpSeHS2fqiVNaoQpFH/NBBcR6oElf6GEvQYMEk6YNAisaNpGF659bf MkGcicSjLFZR3vfpBJOm0pkgOA3VbdcIPVahhwd7RR/a+O5441/uu6ChFFX6qVossdi+ fNTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=MIurMscQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si7673143ejc.493.2021.05.14.07.36.09; Fri, 14 May 2021 07:36:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=MIurMscQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232542AbhENH2h (ORCPT + 99 others); Fri, 14 May 2021 03:28:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233090AbhENH2c (ORCPT ); Fri, 14 May 2021 03:28:32 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF6DC061756 for ; Fri, 14 May 2021 00:27:19 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so940014wmk.1 for ; Fri, 14 May 2021 00:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E9tnZ9evfnbV2gxFSdDXTY64rXupCRZyW/vv9n4TlN8=; b=MIurMscQNGv4VZ6tzwhpDr7DzPbE1lxnX7hhE2XtuM82IE4cR8QJXBCMMNNDnVDg8X XCS/Gx3si6HBXuRHCaCL9DThQ3tLSYbQIoDtBdkHtYmCbZyQvr27pkzhdTLOYJHHWkj6 sqChVKqmNRVjlg/aRd/mMpdqIhS/Ar4iBRJ7ttcdBl0S5tBPC1cmJD4+tgoeWJ0k8B0g xAV6We96t22fmldVwUewaB70BvG5j6kUV0SeRgmail60uzMXgK1e6EaSkNJo1OMKX209 jufk+n4zf2jGz9a4wr9qhPc4WBjVGCLeGppkVo633TCrxHwu5FmBFqjoLMGDzkcDowSl rFRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E9tnZ9evfnbV2gxFSdDXTY64rXupCRZyW/vv9n4TlN8=; b=ufC0vyK4Jg6LLa1EFv7EyjO/iEd+tynJVv7E8G7lxvbBefGnZ0t9/a0Fheb+N5mwk3 xhY+iqcUmdEq4MPJcV0doOkajKLukkOq62GuE81LWrpT5ZWF4iZ7bYCvaeNIMejL3LRg BWYxZWqCwrkBeeKFOvNXVeCO+/CqbDYa7sm+tKN6hDOSHOM3KqBFmI0tMA6YKSamp8bc AfIDMXg7pkrb4otuughrvZh6AWugk08vVptRsCM1YZ9/4XCHAkf57UyEB6OtsfxrbC/p txN1FEzSKuhJt7vfLLBqV0iVybKFx6Nnxxvy+edXA2MNLtYHPHwojFfKStXg9c8cKoDx 7nVw== X-Gm-Message-State: AOAM530frQJKe1L7Nf8RPJu1nlnDZC4nKvFfwr3NvovWLewflBsGhM1R REbF9MOrZiMEz6Slgx944SEPufSpZDMO/mXSwDj1lA== X-Received: by 2002:a05:600c:2315:: with SMTP id 21mr47477543wmo.39.1620977238261; Fri, 14 May 2021 00:27:18 -0700 (PDT) MIME-Version: 1.0 References: <20210513193204.816681-1-davidgow@google.com> <20210513193204.816681-7-davidgow@google.com> <20210514060618.GA3511397@lahna.fi.intel.com> In-Reply-To: <20210514060618.GA3511397@lahna.fi.intel.com> From: David Gow Date: Fri, 14 May 2021 15:27:07 +0800 Message-ID: Subject: Re: [PATCH v2 07/10] thunderbolt: test: Remove sone casts which are no longer required To: Mika Westerberg Cc: Brendan Higgins , Daniel Latypov , Shuah Khan , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 2:08 PM Mika Westerberg wrote: > > Hi, > > On Thu, May 13, 2021 at 12:32:01PM -0700, David Gow wrote: > > With some of the stricter type checking in KUnit's EXPECT macros > > removed, several casts in the thunderbolt KUnit tests are no longer > > required. > > > > Remove the unnecessary casts, making the conditions clearer. > > > > Signed-off-by: David Gow > > Looks good. > > Does this go through KUnit tree or you want me to take it? In case of > the former feel free to add: > > Acked-by: Mika Westerberg > Thanks. I think it's probably easier for this to go in via the KUnit tree, unless Brendan or Shuah have any objections. Cheers, -- David