Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp595187pxj; Fri, 14 May 2021 10:42:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyakThc74RtYkN/Fvh/zsE4TfNFa9vxWNAHLHQ3St792f5E6ty58rhC/hdcaBJHuZD0p5i2 X-Received: by 2002:a92:3610:: with SMTP id d16mr382438ila.16.1621014167112; Fri, 14 May 2021 10:42:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621014167; cv=none; d=google.com; s=arc-20160816; b=fKueRp98bIQI5oc0+/YmsRQzA7vYNoJonT/AAAap5uGTkgFYZeHpvEMAKuluqADJWT L1PAddlbbD/ItxVX1qbOyLydpXoVvI5DUZTrw67EjGHRnI8BhCnZaUqAhQ+luBZ62wcK m0YU2FVLcxjWzOz48fOEO8WUt5cI/4ry3GBYZE8yVbMem9kDTC3uX6JLUJCFUDWzGDsj GgkVirKwKo8GTrjs9JTsm7rMfSOQXiN+cUDmyI48zZ+DPR689TWx69TTf+D7ON2n1aze g7nbLCKz3x5HKD8i8cH/5e53iOCJI3ayUOFSU8qKwU45aXWVfoXSQ3CHNJQPHtITK5QQ J28A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6rU9Jmb715urjTQnIxRXZsEvSyUNf0LlWymw2CPfhOc=; b=nWne3kfUQY5y08P/YeZsEB7ogzcs9hbq0DNWAhVS9gzONMeoDqyFtKPiRlyFs+WWPi fW6azXX2Bc6oIrMj6M6S0I1jjoSO+yJpVYisBzp5uStns7G3S2fnN2DqukQVO0MH19Hg Qck+4g2XklUpbP0rUYyP5TECo9XnFekazWkEmwc41GL3hPL1cIR44K5XyQXFfKrb1j0Z yAYIobgcSr7Zj91ZvOgSRPO85eytFdgvAo/jGQfqcJQs6x5CBdw5uHgsGEX2YQgr20W/ eX0BH11dhk7gi/rwe3uxt8zyklC2KXQr5togb1AN4UWMHI1PKSPqluOB90L9HYOtVhfL adrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BGc4UgXZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si5289205ion.34.2021.05.14.10.42.34; Fri, 14 May 2021 10:42:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BGc4UgXZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbhENLsd (ORCPT + 99 others); Fri, 14 May 2021 07:48:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:60530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhENLsc (ORCPT ); Fri, 14 May 2021 07:48:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C0F3461451; Fri, 14 May 2021 11:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620992841; bh=cqBDYFIise7BzFH9pyRmTy35CizPahqpg4N2b5yr9vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BGc4UgXZHB9JW/LqevKrCXznQZ89zsJJmZfIWgQ0zuvb5o6gWseDNDgSIdTW8+HiG TQ9KG4yq1toN4IsIoFqOs9IsCavh25Q/TBpeUGesik32lXyI5g1x/jxPLpIsxDZUOZ 2tZ4HfDapfN2GGumld/cylkNEZMglMC5HasOUOQY= Date: Fri, 14 May 2021 13:47:17 +0200 From: Greg KH To: Luiz Sampaio Cc: zbr@ioremap.net, corbet@lwn.net, rikard.falkeborn@gmail.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Message-ID: References: <20210409031533.442123-1-sampaio.ime@gmail.com> <20210416221739.501090-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416221739.501090-1-sampaio.ime@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 07:17:33PM -0300, Luiz Sampaio wrote: > The following patches aim to make a user able to calibrate the current > measurement of the DS2438. This chip uses a offset register in page1, which > is added to the current register to give the user the current measurement. > If this value is wrong, the user will get an offset current value, even if > the current is zero, for instance. This patch gives support for reading the > page1 registers (including the offset register) and for writing to the > offset register. The DS2438 datasheet shows a calibration routine, and with > this patch, the user can do this quickly by writing the correct value to > the offset register. This patch was tested on real hardware using a power > supply and an electronic load. > Please help to review this series of patches. > > Best regards! > Sampaio > --- > Changes in v7: > - Build test again Can you fix the warning in patch 6/6 that the kernel test robot found, and resend? thanks, greg k-h