Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp630053pxj; Fri, 14 May 2021 11:32:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIQKdLy38S+kjXIwjdcnHQjrpZN7wvdpKosokMOauWX/C2HsGmoiQmWMvIHrdr3cNi3OE2 X-Received: by 2002:a17:906:a48:: with SMTP id x8mr49959800ejf.127.1621017177267; Fri, 14 May 2021 11:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621017177; cv=none; d=google.com; s=arc-20160816; b=VcwxnjHfUKQC6ptaMJxjuGypFPR9o9D3gh0IYnhbaHmhMzl6RyXB/UJxEUpdVRHFdG w1u7c2TyqYNgGrZhhWDDYHtlhWqiOy2dL0bHNdE0aZebS03PpzDmVmOT1F8iZhsS7UkK Pcysw0hjhZWP0k90tPN2658gF4j7OY6x55LgaIsF72PCn96pmJ/RG/iuwL7+2daiD7gO GSoZvLrpjOog0dbVByKDz22UU6su29FwFEui/skD/9RbwgMOROiFjlJLyLATDh1N9KFs PbbcISr+KxuP1cWs0/r8mA4Wl8xpstjAYIm4qWHNqeKh3tgN0vL3wLxQb+09lo4DhZ3R u3RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Pwu5ljpbBD7NI3gA0zwbOLR6Z5gubXbc/7oJT235HwY=; b=mrIQWX7YIyVIL+LJzucYoyhiMtE5o2LFdAgntJO2U7qn/1LTYtoZNVQbquG5SP3wOZ GxaJLloyFrUOqoaBQoCMwCmRcP1PSYyklRTtgVl5B1eGHIoc+sjBoE8kz1eCqpvnh9mh AR5FtWSORWM2qiDWBNc0rAs79Ehs0uc47vB3Nm1fI81jumBRpBiyaarFhAHAR33udGxM t/1nZ3fgezfPQ86HvjzF3pBxaPYGLTge7ov9CoTZS8PmB5edRgvmKKaHw+MuxzvygJS2 bGMlnR7iFlfBnPqN9yUoHm/sMDJw6Qw+B9/rBwmenwWJlsO40KJiOgksgUhz31gLXe69 Yqyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C9E8ZPN0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ho39si3379235ejc.563.2021.05.14.11.32.33; Fri, 14 May 2021 11:32:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C9E8ZPN0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233860AbhENNFl (ORCPT + 99 others); Fri, 14 May 2021 09:05:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:49584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231518AbhENNFk (ORCPT ); Fri, 14 May 2021 09:05:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 00ADE613B5; Fri, 14 May 2021 13:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620997469; bh=hrSgVsZqaRBcljBBqNyheSc8FOIB8bhn2v+R26pY0do=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C9E8ZPN0XCkJyfjkn+NTGxiHrRCs+QgHfH3Nhgd4S8+LFU14eN5D6MdzufXrK4Ozu QPi5zdYOVim4TNd7zGJirTf8aDyp10SzV8j5RvAutfl+s/4Afml2bPn1I5ndVghBXu XV1avhSVcY6uLcEMdmD3DtTa+Vl9R18sb+3frWu7YF3kGITx5vwdVLxHylRDK1yNZI vbFEZ6IeI/2z/SQCO59xKJxwJUHnnnsuLyOX21xjKJBpi6XWRphLOuG4exYqLsBe9J eUtBwcuRLWzm+tXPakNwJnisb209yL165zqFxnFuC0dRDqA1ys810A0x0O6c9vPpu7 hqmvq4JPEiXNQ== Date: Fri, 14 May 2021 09:04:27 -0400 From: Sasha Levin To: David Ward Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Pierre-Louis Bossart , Mark Brown , alsa-devel@alsa-project.org Subject: Re: [PATCH AUTOSEL 5.12 090/116] ASoC: rt286: Generalize support for ALC3263 codec Message-ID: References: <20210505163125.3460440-1-sashal@kernel.org> <20210505163125.3460440-90-sashal@kernel.org> <55cb81cd-4eb9-049a-abf6-d4628ac8cb34@gatech.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <55cb81cd-4eb9-049a-abf6-d4628ac8cb34@gatech.edu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 07, 2021 at 12:34:29AM -0400, David Ward wrote: >On 5/5/21 12:30 PM, Sasha Levin wrote: >>From: David Ward >> >>[ Upstream commit aa2f9c12821e6a4ba1df4fb34a3dbc6a2a1ee7fe ] >> >>The ALC3263 codec on the XPS 13 9343 is also found on the Latitude 13 7350 >>and Venue 11 Pro 7140. They require the same handling for the combo jack to >>work with a headset: GPIO pin 6 must be set. >> >>The HDA driver always sets this pin on the ALC3263, which it distinguishes >>by the codec vendor/device ID 0x10ec0288 and PCI subsystem vendor ID 0x1028 >>(Dell). The ASoC driver does not use PCI, so adapt this check to use DMI to >>determine if Dell is the system vendor. > >For this patch to be useful, commit cd8499d5c03b ("ASoC: rt286: Make >RT286_SET_GPIO_* readable and writable") from the same series is >needed as well, which fixed the regmap config. > >(The same comment is true for all stable branches.) I'll take it too, thanks! -- Thanks, Sasha