Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org, John Crispin <john@phrozen.org>
Cc:     Lee Jones <lee.jones@linaro.org>, kernel test robot <lkp@intel.com>
References: <20210514131750.52867-1-krzysztof.kozlowski@canonical.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <2b427eca-fd6c-d099-337f-39cfbd85cb46@roeck-us.net>
Date:   Fri, 14 May 2021 06:48:58 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210514131750.52867-1-krzysztof.kozlowski@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
> When rt2880_wdt watchdog driver is built as a module, the
> rt_sysc_membase needs to be exported (it is being used via inlined
> rt_sysc_r32):
> 
>    ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

I don't see a recent change in the code. Has that problem been there
all along ?

Thanks,
Guenter

> ---
>   arch/mips/ralink/of.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
> index 0c5de07da097..b3ce706426c4 100644
> --- a/arch/mips/ralink/of.c
> +++ b/arch/mips/ralink/of.c
> @@ -24,6 +24,8 @@
>   #include "common.h"
>   
>   __iomem void *rt_sysc_membase;
> +EXPORT_SYMBOL_GPL(rt_sysc_membase);
> +
>   __iomem void *rt_memc_membase;
>   
>   __iomem void *plat_of_remap_node(const char *node)
>