Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: LwYnGsfH5r8MHMsJorF5DTV6eA9mSjH7a7RAgxJPy4WleTJmhL7w13cb39wZfPqIaDi62N2Kvs
 8iHVpiAWGJoQ==
IronPort-SDR: NYZ/ZBR/M0sAt8ivx97pC7M6FKT4juXxZRKMSUCEE3kS0v4jCEqywJk93Tmvt4ULuBpzpSShKA
 VgKadPuAfdKQ==
From:   "Kaneda, Erik" <erik.kaneda@intel.com>
To:     Wei Ming Chen <jj251510319013@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "devel@acpica.org" <devel@acpica.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH] ACPICA: Use ACPI_FALLTHROUGH
Thread-Topic: [PATCH] ACPICA: Use ACPI_FALLTHROUGH
Thread-Index: AQHXRzXLfMTR2xfx+EGhKhkGGYYxqKrjO9lA
Date:   Fri, 14 May 2021 17:19:37 +0000
Message-ID: <MWHPR11MB1599C04B3AAA3A1A14A0D7FCF0509@MWHPR11MB1599.namprd11.prod.outlook.com>
References: <20210512135018.20253-1-jj251510319013@gmail.com>
In-Reply-To: <20210512135018.20253-1-jj251510319013@gmail.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c40f848-558e-439e-892e-08d916fc7365
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2021 17:19:37.1720
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X6Awfge9r4ud0B/50X+2D39D1uxItCqvDMT+LqX/xkW7K9TY66XIYPImNPfSkqx41Pxgx2cY3IDEV7VBQ/33gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5042
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Wei Ming Chen <jj251510319013@gmail.com>
> Sent: Wednesday, May 12, 2021 6:50 AM
> To: linux-kernel@vger.kernel.org
> Cc: Kaneda, Erik <erik.kaneda@intel.com>; devel@acpica.org; linux-
> acpi@vger.kernel.org; Wei Ming Chen <jj251510319013@gmail.com>
> Subject: [PATCH] ACPICA: Use ACPI_FALLTHROUGH
>=20
> Replace /* FALLTHROUGH */ comment with ACPI_FALLTHROUGH
>=20
> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
>  drivers/acpi/acpica/utprint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.=
c
> index e37d612e8db5..05426596d1f4 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const cha=
r
> *format, va_list args)
>  		case 'X':
>=20
>  			type |=3D ACPI_FORMAT_UPPER;
> -			/* FALLTHROUGH */
> +			ACPI_FALLTHROUGH;
>=20
>  		case 'x':
>=20
> --
> 2.25.1

I made a pull request here: https://github.com/acpica/acpica/pull/688
I'll circulate it to Linux upstream after we do a release (about once per m=
onth).

Thanks,
Erik=20