Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Maximilian Luz <luzmaximilian@gmail.com>,
        Sachi King <nakato@nakato.io>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        David Laight <David.Laight@aculab.com>
Cc:     "H. Peter Anvin" <hpa@zytor.com>,
        "x86\@kernel.org" <x86@kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable\@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/i8259: Work around buggy legacy PIC
In-Reply-To: <5c08541a-2615-f075-a189-0462f1005007@gmail.com>
References: <20210512210459.1983026-1-luzmaximilian@gmail.com> <e7dbd4d1-f23f-42f0-e912-032ba32f9ec8@gmail.com> <e43d9a823c9e44bab0cdbf32a000c373@AcuMS.aculab.com> <3034083.sOBWI1P7ec@yuki> <5c08541a-2615-f075-a189-0462f1005007@gmail.com>
Date:   Fri, 14 May 2021 19:32:54 +0200
Message-ID: <87im3l43w9.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Fri, May 14 2021 at 13:58, Maximilian Luz wrote:
> On 5/14/21 9:41 PM, Sachi King wrote:
> I'd assume that _some_ sort of interrupt setup is done by the BIOS/UEFI.
> The UEFI on those devices is fairly well-featured, with touch support
> via SPI and all. Furthermore, keyboard (also supported in the device's
> UEFI) is handled via a custom UART protocol. Unless they rely on polling
> for all of that, I believe they'd have to set up some interrupts.

Polling would be truly surprising.

> Although, as you mention later on, that could also be handled via the
> IOAPIC and the PIC is actually not supposed to be used. Maybe some
> legacy component that never got tested and just broke with some new
> hardware/firmware revision without anyone noticing? And since Linux
> still seems to rely on that, we might be the first to notice.

That's a valid assumption. As I said, we can make IOAPIC work even w/o
PIC. I'll have a look how much PIC assumptions are still around.

Thanks,

        tglx