Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210514065912.71734-1-pulehui@huawei.com>
In-Reply-To: <20210514065912.71734-1-pulehui@huawei.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Fri, 14 May 2021 11:48:48 -0700
Message-ID: <CAHbLzkonsd9f=48+cxKOJamNb9e8qpvWJCYDGFB_wNTdET2zmQ@mail.gmail.com>
Subject: Re: [PATCH -next] mm/huge_memory.c: remove unused variable 'count'
To:     Pu Lehui <pulehui@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 13, 2021 at 11:59 PM Pu Lehui <pulehui@huawei.com> wrote:
>
> mm/huge_memory.c:2663:6: warning:
>  variable =E2=80=98count=E2=80=99 set but not used [-Wunused-but-set-vari=
able]
>   2663 |  int count, mapcount, extra_pins, ret;
>        |      ^~~~~
>
> This variable is not used in function , this commit
> remove it to fix the warning.

Thanks for catching this warning. Not sure why my gcc 10 doesn't catch
this warning at all. What compiler are you using?

Andrew, the compile warning was introduced by my
mm-thp-check-total_mapcount-instead-of-page_mapcount.patch.
>
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
> ---
>  mm/huge_memory.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 52ca04b905cf..a23a127302e9 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2660,7 +2660,7 @@ int split_huge_page_to_list(struct page *page, stru=
ct list_head *list)
>         struct deferred_split *ds_queue =3D get_deferred_split_queue(head=
);
>         struct anon_vma *anon_vma =3D NULL;
>         struct address_space *mapping =3D NULL;
> -       int count, mapcount, extra_pins, ret;
> +       int mapcount, extra_pins, ret;
>         pgoff_t end;
>
>         VM_BUG_ON_PAGE(is_huge_zero_page(head), head);
> @@ -2737,7 +2737,6 @@ int split_huge_page_to_list(struct page *page, stru=
ct list_head *list)
>
>         /* Prevent deferred_split_scan() touching ->_refcount */
>         spin_lock(&ds_queue->split_queue_lock);
> -       count =3D page_count(head);
>         mapcount =3D total_mapcount(head);
>         if (!mapcount && page_ref_freeze(head, 1 + extra_pins)) {
>                 if (!list_empty(page_deferred_list(head))) {
> --
> 2.17.1
>
>