Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp696850pxj; Fri, 14 May 2021 13:23:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxN+DYQimXqZLxROfSc509qnGJ3Tdo0WhSu6S19yz+9bcayAzaOAK5SBAubT4f/+aBu+mUC X-Received: by 2002:a02:9621:: with SMTP id c30mr3515646jai.113.1621023833400; Fri, 14 May 2021 13:23:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621023833; cv=none; d=google.com; s=arc-20160816; b=saOkr08RQGy4IZBXp3BB4LoCLZAxizmqtgKcBiIwaP+j0ghVt804gOAM09kQBilzw1 C85PRR+O93Sjbxhd8BhjqwVHcehZ3aWl874Atd0Bz45jepODH40ev5fZUW0rQt6c/0gU f66gU02HNvFjkRDRvL1thNtd8SlNl3O6OQqzoVZYkPdS+LmpDQqe5hgDbmiORssRMtwx r6nbFsiwqQRCNwLtCtlApvXUPpZL4MySvizDaXZCfW+H8jrFaK3tHMLeM12M8JJ/RV+h kaEs7Mj5Y4VSbPMhTI4hDdzIsUUPCSVZs12jVCzaB0/QpzMIM7omXoJkqbUiebfr3JM3 g6wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2oyWB47DVh2Z1QlH8RDV8bFzaQjwvqlwdoVeOlHpTjY=; b=zO+wiWq11ztBYr9Q1QmVOvU9leIFqCsofXQ9Z5O6deVfK6BnXPpXugsiDkVkvROUsW foEdRSowmlZQvFNML47fJMsKB5Dr+aAUGRpdZpw2IcU25O1IqROS7JJjo7Z3/mKMyVlW nqWCSo3F+fWzb5TYWeW52pMlY2gwf+x87rkrwurSXYsIu7tRukCwHPpnrV16W03FDKQY yzbjw45F9cJB54zYllJYBAdRV6Zpc8DcRI5o+faR6jZ815LNQo8le+HcWmGSiXhK+kDk rwvBJPVfM9guFZmT1pOSPq40iy6txGxwe4dh9HD7e179KmgvraN8U/r4ujvS2w7cWIRJ JT6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=N7xVGKEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a27si8714492jab.118.2021.05.14.13.23.40; Fri, 14 May 2021 13:23:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=N7xVGKEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233825AbhENTGQ (ORCPT + 99 others); Fri, 14 May 2021 15:06:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232273AbhENTGQ (ORCPT ); Fri, 14 May 2021 15:06:16 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48A43C061574 for ; Fri, 14 May 2021 12:05:04 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id ep16-20020a17090ae650b029015d00f578a8so288822pjb.2 for ; Fri, 14 May 2021 12:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2oyWB47DVh2Z1QlH8RDV8bFzaQjwvqlwdoVeOlHpTjY=; b=N7xVGKEZAXnH63GpXE5YnML5NzFhi5pHSpODhdP/+SHXypBf+ks4urojkWF+Ax4bXJ H9elgm+fGXV0S5oqzNOAJNQmqcxAsHqbr2rN+1FBkvyF2WznF6gFOSPjTXX5SglQyi2y LXNsTtw2ir4m0hJtlXyLOuM593MKZvmymmOBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2oyWB47DVh2Z1QlH8RDV8bFzaQjwvqlwdoVeOlHpTjY=; b=Asx3wU9q2livkBlCWDTNFavwDF2Lxbs9BqDZYDrWWV+nE5Mm+g2emAJeg0l+H3vX9C +TJoQBfAFmI+GYcW+JhI8ypEYHodYSOLO6J9C9MSRRNLK03uBcT/UlhM7tHZ0QHAJ2du cVOZkC8UqjtvEgb4JfinLRvwU5fa/DIPeQjyk7S8IHIZRjjuUZP/o9NL+kQZ2gdvduG2 JJKWCSEP/imrLnowMF76Sy6IZ3QOpg55ARI7uFhvPhd/L30qulqbBu73qPtUNoYJ48yH +aY6iA0OrLVOJrFl5o/h6HRS0BWBotvQFBNWQ7fGoTuUAgKXHKWEmChGXcpmWddfai2V xZow== X-Gm-Message-State: AOAM531CKMKoUNR2XOpSMzn6vbcd15xJxBzACOnTDK8VFcPdYJ2UCQEl hzhXKuc1ErlqqCT6iFJZPScIHw== X-Received: by 2002:a17:902:860b:b029:ef:46b8:886e with SMTP id f11-20020a170902860bb02900ef46b8886emr24070539plo.18.1621019103903; Fri, 14 May 2021 12:05:03 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v67sm4506950pfb.205.2021.05.14.12.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 12:05:03 -0700 (PDT) Date: Fri, 14 May 2021 12:05:02 -0700 From: Kees Cook To: Casey Schaufler Cc: casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH v26 08/25] LSM: Use lsmblob in security_secid_to_secctx Message-ID: <202105141204.B7691DAD26@keescook> References: <20210513200807.15910-1-casey@schaufler-ca.com> <20210513200807.15910-9-casey@schaufler-ca.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210513200807.15910-9-casey@schaufler-ca.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 01:07:50PM -0700, Casey Schaufler wrote: > Change security_secid_to_secctx() to take a lsmblob as input > instead of a u32 secid. It will then call the LSM hooks > using the lsmblob element allocated for that module. The > callers have been updated as well. This allows for the > possibility that more than one module may be called upon > to translate a secid to a string, as can occur in the > audit code. > > Signed-off-by: Casey Schaufler This looks sensible. Reviewed-by: Kees Cook -- Kees Cook