Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Va9ZVF8fijqzHqkFjkT9dbepwe5KLqGKVBbamsKUQJWXhOsS4LcVEQu3VsqL2puurFCtzGijKn
 unxrsRtUni+Q==
IronPort-SDR: tCSdz899VH5JJU8cO3QGNvawjmbQ0pbYXGZeGsr3S5AvmMZR+bisRoQRv/wld6f0/vIusXNZ8V
 QOAcdpp8Li4Q==
Date:   Fri, 14 May 2021 13:22:51 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     Edgecombe@iweiny-DESK2.sc.intel.com,
        Rick P <rick.p.edgecombe@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Dan Williams <dan.j.williams@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH V6 00/10] PKS: Add Protection Key Supervisor support
Message-ID: <20210514202250.GA1722585@iweiny-DESK2.sc.intel.com>
References: <20210401225833.566238-1-ira.weiny@intel.com>
 <20210416220950.GE1904484@iweiny-DESK2.sc.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210416220950.GE1904484@iweiny-DESK2.sc.intel.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Fri, Apr 16, 2021 at 03:14:56PM -0700, 'Ira Weiny' wrote:
> On Thu, Apr 01, 2021 at 03:58:23PM -0700, 'Ira Weiny' wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > Introduce a new page protection mechanism for supervisor pages, Protection Key
> > Supervisor (PKS).
> 
> Is there any feedback on this series?

Please disregard this series...  (If you have not done so already).

Along with Rick posting his RFC for page table protections[1] he has raised a
concern with me about pkeys being allocated and then reallocated to another
user.  It turns out the code has a bug in this area and the fix is not trivial.

Because the PMEM use case never needed to free its key and even if it did a
small window of access was not a concern this was not tested.

The best solutions involve changing the API therefore this series is going to
need a respin.

Thank you,
Ira

[1] https://lore.kernel.org/lkml/20210505003032.489164-1-rick.p.edgecombe@intel.com/