Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161398AbWJZOJF (ORCPT ); Thu, 26 Oct 2006 10:09:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161399AbWJZOJF (ORCPT ); Thu, 26 Oct 2006 10:09:05 -0400 Received: from mx1.redhat.com ([66.187.233.31]:27802 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1161398AbWJZOJE (ORCPT ); Thu, 26 Oct 2006 10:09:04 -0400 From: David Howells In-Reply-To: <4540BEFC.4080502@sw.ru> References: <4540BEFC.4080502@sw.ru> <4540A0C5.60700@sw.ru> <453F58FB.4050407@sw.ru> <19857.1161869015@redhat.com> To: Vasily Averin Cc: aviro@redhat.com, Neil Brown , Jan Blunck , Olaf Hering , Balbir Singh , Kirill Korotaev , Linux Kernel Mailing List , devel@openvz.org, Andrew Morton Subject: Re: [Q] missing unused dentry in prune_dcache()? X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Thu, 26 Oct 2006 15:07:32 +0100 Message-ID: <20675.1161871652@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 16 Vasily Averin wrote: > I would note that in first two hunks you have decremented > dentry_stat.nr_unused correctly, under dcache_lock. Probably it's better to > count freed dentries only in third case and corrects dentry_stat.nr_unused > value inside shrink_dcache_for_umount_subtree() function before return. Maybe, maybe not. This way we only touch the dentry_stat cacheline once, if at all. I'm not sure it'd make much difference though. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/