Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 May 2021 15:08:55 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Moriis Ku <saumah@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add SUNIX SDC series mfd driver
Message-ID: <20210514140855.GG805368@dell>
References: <20210514112743.4813-1-saumah@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210514112743.4813-1-saumah@gmail.com>
Precedence: bulk

On Fri, 14 May 2021, Moriis Ku wrote:

> From: Morris Ku <saumah@gmail.com>
> 
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
>  sdc_mfd.c | 691 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  sdc_mfd.h |  58 +++++
>  sdc_pci.c | 100 ++++++++
>  3 files changed, 849 insertions(+)
>  create mode 100644 sdc_mfd.c
>  create mode 100644 sdc_mfd.h
>  create mode 100644 sdc_pci.c

Please read and adhere to the upstreaming documentation [0] before
submitting any more patches.  There are lots of basic issues with this
patch.

If after reading, you still don't know what I'm referring to, let me
know and I'll do a very quick review just to point you in the right
direction.

Must better if you can use and digest the docs though, it will serve
you well in the future.

[0] Start here: Documentation/process/

> diff --git a/sdc_mfd.c b/sdc_mfd.c
> new file mode 100644
> index 0000000..dc30f3b
> --- /dev/null
> +++ b/sdc_mfd.c
> @@ -0,0 +1,691 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * SUNIX SDC mfd driver.
> + *
> + * Copyright (C) 2021, SUNIX Co., Ltd.
> + *
> + * Authors: Jason Lee <jason_lee@sunix.com>
> + */

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog